Обсуждение: WRITE_*_ARRAY macros for outfuncs.c

Поиск
Список
Период
Сортировка

WRITE_*_ARRAY macros for outfuncs.c

От
Peter Eisentraut
Дата:
In readfuncs.c, we have READ_ATTRNUMBER_ARRAY, READ_OID_ARRAY,
READ_INT_ARRAY, READ_BOOL_ARRAY, but the writing side in outfuncs.c is
coded by hand in each case.  Any reason for this?

Here is a patch that adds WRITE_ATTRNUMBER_ARRAY, WRITE_OID_ARRAY,
WRITE_INT_ARRAY, WRITE_BOOL_ARRAY.  That seems much nicer.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Вложения

Re: WRITE_*_ARRAY macros for outfuncs.c

От
Tom Lane
Дата:
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> In readfuncs.c, we have READ_ATTRNUMBER_ARRAY, READ_OID_ARRAY,
> READ_INT_ARRAY, READ_BOOL_ARRAY, but the writing side in outfuncs.c is
> coded by hand in each case.  Any reason for this?

> Here is a patch that adds WRITE_ATTRNUMBER_ARRAY, WRITE_OID_ARRAY,
> WRITE_INT_ARRAY, WRITE_BOOL_ARRAY.  That seems much nicer.

LGTM.

            regards, tom lane