Обсуждение: pgsql: Initialize random() in bootstrap/stand-alone postgres and inini

Поиск
Список
Период
Сортировка

pgsql: Initialize random() in bootstrap/stand-alone postgres and inini

От
Noah Misch
Дата:
Initialize random() in bootstrap/stand-alone postgres and in initdb.

This removes a difference between the standard IsUnderPostmaster
execution environment and that of --boot and --single.  In a stand-alone
backend, "SELECT random()" always started at the same seed.

On a system capable of using posix shared memory, initdb could still
conclude "selecting dynamic shared memory implementation ... sysv".
Crashed --boot or --single postgres processes orphaned shared memory
objects having names that collided with the not-actually-random names
that initdb probed.  The sysv fallback appeared after ten crashes of
--boot or --single postgres.  Since --boot and --single are rare in
production use, systems used for PostgreSQL development are the
principal candidate to notice this symptom.

Back-patch to 9.3 (all supported versions).  PostgreSQL 9.4 introduced
dynamic shared memory, but 9.3 does share the "SELECT random()" problem.

Reviewed by Tom Lane and Kyotaro HORIGUCHI.

Discussion: https://postgr.es/m/20180915221546.GA3159382@rfd.leadboat.com

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/4232cff11b84ddb7440bc2fdc3a5bd6ab0baeea4

Modified Files
--------------
src/backend/utils/init/miscinit.c | 8 ++++++++
src/bin/initdb/initdb.c           | 3 +++
2 files changed, 11 insertions(+)