Block replication slot advance for these not yet reserving WAL
Such replication slots are physical slots freshly created without WAL
being reserved, which is the default behavior, which have not been used
yet as WAL consumption resources to retain WAL. This prevents advancing
a slot to a position older than any WAL available, which could falsify
calculations for WAL segment recycling.
This also cleans up a bit the code, as ReplicationSlotRelease() would be
called on ERROR, and improves error messages.
Reported-by: Kyotaro Horiguchi
Author: Michael Paquier
Reviewed-by: Andres Freund, Álvaro Herrera, Kyotaro Horiguchi
Discussion: https://postgr.es/m/20180626071305.GH31353@paquier.xyz
Branch
------
REL_11_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/9069eb95f48c8200f8589faf7adc5e324eed25cd
Modified Files
--------------
contrib/test_decoding/expected/slot.out | 17 +++++++++++++++++
contrib/test_decoding/sql/slot.sql | 6 ++++++
doc/src/sgml/catalogs.sgml | 3 ++-
src/backend/replication/slotfuncs.c | 13 ++++++++-----
4 files changed, 33 insertions(+), 6 deletions(-)