Обсуждение: pg_control read error message

On 18/05/18 14:32, Magnus Hagander wrote:
> If pg_control is for some reason empty, we give an error messagfe like:
> 
> 2018-05-18 13:24:03.342 CEST [19697] PANIC:  could not read from control
> file: Success
> 
> Which is, uh, wrong -- it's definitely not successful.
> 
> Obviously this is a state where the user is fairly screwed anyway, but we
> should give a better message.
> 
> Attached is a patch that does this. Reasonable?

Looks good to me.

- Heikki

On Fri, May 18, 2018 at 03:54:47PM +0300, Heikki Linnakangas wrote:
> Looks good to me.

+1 for fixing that.  get_controlfile() in controldata_utils.c also needs
to be fixed.
--
Michael

Heikki Linnakangas <hlinnaka@iki.fi> writes:
> On 18/05/18 14:32, Magnus Hagander wrote:
>> If pg_control is for some reason empty, we give an error messagfe like:
>> 2018-05-18 13:24:03.342 CEST [19697] PANIC:  could not read from control
>> file: Success
>> Which is, uh, wrong -- it's definitely not successful.
>> Obviously this is a state where the user is fairly screwed anyway, but we
>> should give a better message.
>> Attached is a patch that does this. Reasonable?

> Looks good to me.

Only comment I have is that I think there's similar shortcuts in a lot
of places :-(

            regards, tom lane

On Fri, May 18, 2018 at 10:22:29AM -0400, Tom Lane wrote:
> Only comment I have is that I think there's similar shortcuts in a lot
> of places :-(

Yeah.  A quick lookup is showing me one in xlog.c (XLOG_BLCKSZ) and one
in pg_rewind.  (Spotted roughly 392 places to look at in all the core
code).  Let's discuss that on a separate thread.
--
Michael