Обсуждение: MSYS2 and pg_upgrade testing

I've been getting an Msys2 environment working, and will soon document
how to build with this environment. There are several nice things
about it, including a modern version of perl and proper support for
the mingw-w64 compilers.

So far the only thing I have found that needs to be changed for us to
support it is this, which is so trivial and low risk that I propose to
backpatch it to all live releases:

diff --git a/src/bin/pg_upgrade/test.sh b/src/bin/pg_upgrade/test.sh
index a805018..45ccd8f 100644
--- a/src/bin/pg_upgrade/test.sh
+++ b/src/bin/pg_upgrade/test.sh
@@ -34,7 +34,7 @@ standard_initdb() {
 testhost=`uname -s`

 case $testhost in
-   MINGW*)
+   MINGW*|MSYS*)
        LISTEN_ADDRESSES="localhost"
        PGHOST=localhost
        ;;


cheers

andrew

-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

On Thu, May 3, 2018 at 5:25 PM, Andrew Dunstan
<andrew.dunstan@2ndquadrant.com> wrote:
> I've been getting an Msys2 environment working, and will soon document
> how to build with this environment. There are several nice things
> about it, including a modern version of perl and proper support for
> the mingw-w64 compilers.
>
> So far the only thing I have found that needs to be changed for us to
> support it is this, which is so trivial and low risk that I propose to
> backpatch it to all live releases:
>
> diff --git a/src/bin/pg_upgrade/test.sh b/src/bin/pg_upgrade/test.sh
> index a805018..45ccd8f 100644
> --- a/src/bin/pg_upgrade/test.sh
> +++ b/src/bin/pg_upgrade/test.sh
> @@ -34,7 +34,7 @@ standard_initdb() {
>  testhost=`uname -s`
>
>  case $testhost in
> -   MINGW*)
> +   MINGW*|MSYS*)
>         LISTEN_ADDRESSES="localhost"
>         PGHOST=localhost
>         ;;

It's astonishing that's the only thing that needs to change!

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, May 4, 2018 at 2:30 PM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Thu, May 3, 2018 at 5:25 PM, Andrew Dunstan
> <andrew.dunstan@2ndquadrant.com> wrote:
>> I've been getting an Msys2 environment working, and will soon document
>> how to build with this environment. There are several nice things
>> about it, including a modern version of perl and proper support for
>> the mingw-w64 compilers.
>>
>> So far the only thing I have found that needs to be changed for us to
>> support it is this, which is so trivial and low risk that I propose to
>> backpatch it to all live releases:
>>
>> diff --git a/src/bin/pg_upgrade/test.sh b/src/bin/pg_upgrade/test.sh
>> index a805018..45ccd8f 100644
>> --- a/src/bin/pg_upgrade/test.sh
>> +++ b/src/bin/pg_upgrade/test.sh
>> @@ -34,7 +34,7 @@ standard_initdb() {
>>  testhost=`uname -s`
>>
>>  case $testhost in
>> -   MINGW*)
>> +   MINGW*|MSYS*)
>>         LISTEN_ADDRESSES="localhost"
>>         PGHOST=localhost
>>         ;;
>
> It's astonishing that's the only thing that needs to change!
>


I might find more stuff as I go along, but this change was enough for
me to be able to do a full buildfarm client run.

cheers

andrew


-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services