Re: bugfifx: a minor mistake in brin_inclusion.c comment

От:

Alvaro Herrera <alvherre@alvh.no-ip.org>

Дата:

26 марта 2018 г. в 18:11:26

Tomas Vondra wrote:
> Hi,
> 
> while looking at brin_inclusion.c, I've noticed that the comment about
> INCLUSION_UNMERGEABLE and INCLUSION_CONTAINS_EMPTY uses incorrect values
> (1 instead of 2). Attached is a simple fix.

Uh, yeah, this is wrong.

> But perhaps it would be better to use the constants in the comment.

I fixed it like this, which seems neater.

Thanks!

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

bugfifx: a minor mistake in brin_inclusion.c comment

От:

Tomas Vondra <tomas.vondra@2ndquadrant.com>

Дата:

23 марта 2018 г. в 03:32:55

Hi,

while looking at brin_inclusion.c, I've noticed that the comment about
INCLUSION_UNMERGEABLE and INCLUSION_CONTAINS_EMPTY uses incorrect values
(1 instead of 2). Attached is a simple fix.

But perhaps it would be better to use the constants in the comment.

regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services