Обсуждение: [pgAdmin4][RM#3161] Fix PEP-8 issues

Поиск
Список
Период
Сортировка

[pgAdmin4][RM#3161] Fix PEP-8 issues

От
Murtuza Zabuawala
Дата:
Hi,

PFA patch to fix the PEP8 issues in Casts, Event triggers, Extensions and Languages module.

pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/servers/databases/languages/
pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/servers/databases/extensions/
pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/servers/databases/event_triggers/
pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/servers/databases/casts/

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Вложения

Re: [pgAdmin4][RM#3161] Fix PEP-8 issues

От
Joao De Almeida Pereira
Дата:
Hello Murtuza,

I passed the patch through our CI and all test are green. Also run the codestyle in all those folders and everything is clean.

575 issues to go

Thanks
Joao

On Wed, Feb 28, 2018 at 1:05 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to fix the PEP8 issues in Casts, Event triggers, Extensions and Languages module.

pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/servers/databases/languages/
pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/servers/databases/extensions/
pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/servers/databases/event_triggers/
pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/servers/databases/casts/

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgAdmin4][RM#3161] Fix PEP-8 issues

От
Murtuza Zabuawala
Дата:
Thank you Joao for reviewing.

On Thu, Mar 1, 2018 at 3:10 AM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hello Murtuza,

I passed the patch through our CI and all test are green. Also run the codestyle in all those folders and everything is clean.

575 issues to go

Thanks
Joao

On Wed, Feb 28, 2018 at 1:05 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to fix the PEP8 issues in Casts, Event triggers, Extensions and Languages module.

pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/servers/databases/languages/
pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/servers/databases/extensions/
pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/servers/databases/event_triggers/
pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/servers/databases/casts/

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Re: [pgAdmin4][RM#3161] Fix PEP-8 issues

От
Dave Page
Дата:
Thanks, applied.

On Thu, Mar 1, 2018 at 5:13 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Thank you Joao for reviewing.

On Thu, Mar 1, 2018 at 3:10 AM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hello Murtuza,

I passed the patch through our CI and all test are green. Also run the codestyle in all those folders and everything is clean.

575 issues to go

Thanks
Joao

On Wed, Feb 28, 2018 at 1:05 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to fix the PEP8 issues in Casts, Event triggers, Extensions and Languages module.

pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/servers/databases/languages/
pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/servers/databases/extensions/
pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/servers/databases/event_triggers/
pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/servers/databases/casts/

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company





--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company