Обсуждение: [pgAdmin4][RM#3062] Fix PEP-8 issues in Tools module

Поиск
Список
Период
Сортировка

[pgAdmin4][RM#3062] Fix PEP-8 issues in Tools module

От
Murtuza Zabuawala
Дата:
Hi,

PFA patch to fix PEP-8 issues in Tools module's python code.

How to run,
1) Apply patch RM#3063
2) activate virtual environemt
3) Install pycodestyle (formerly called pep8) module from requirements.txt 
4) Navigate to ../web directory and run following
pycodestyle --config=.pycodestyle ./pgadmin/tools

In step-4, you can also run yarn run pep8 for whole project but as of now I have fixed only tools module, that's why I'm suggesting you to run it against Tools module only :)

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Вложения

Re: [pgAdmin4][RM#3062] Fix PEP-8 issues in Tools module

От
Dave Page
Дата:
Thanks, patch applied.

On Fri, Jan 26, 2018 at 1:26 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to fix PEP-8 issues in Tools module's python code.

How to run,
1) Apply patch RM#3063
2) activate virtual environemt
3) Install pycodestyle (formerly called pep8) module from requirements.txt 
4) Navigate to ../web directory and run following
pycodestyle --config=.pycodestyle ./pgadmin/tools

In step-4, you can also run yarn run pep8 for whole project but as of now I have fixed only tools module, that's why I'm suggesting you to run it against Tools module only :)

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company