Обсуждение: pgsql: Try again to fix accumulation of parallel workerinstrumentation

Поиск
Список
Период
Сортировка

pgsql: Try again to fix accumulation of parallel workerinstrumentation

От
Robert Haas
Дата:
Try again to fix accumulation of parallel worker instrumentation.

When a Gather or Gather Merge node is started and stopped multiple
times, accumulate instrumentation data only once, at the end, instead
of after each execution, to avoid recording inflated totals.

Commit 778e78ae9fa51e58f41cbdc72b293291d02d8984, the previous attempt
at a fix, instead reset the state after every execution, which worked
for the general instrumentation data but had problems for the additional
instrumentation specific to Sort and Hash nodes.

Report by hubert depesz lubaczewski.  Analysis and fix by Amit Kapila,
following a design proposal from Thomas Munro, with a comment tweak
by me.

Discussion: http://postgr.es/m/20171127175631.GA405@depesz.com

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/72567f6174605c36ba520c80e71697d2601cac0a

Modified Files
--------------
src/backend/executor/execParallel.c           | 20 ++++++++++----------
src/test/regress/expected/select_parallel.out | 21 +++++++++++++++++++++
src/test/regress/sql/select_parallel.sql      |  7 +++++++
3 files changed, 38 insertions(+), 10 deletions(-)