Обсуждение: Re: [sqlsmith] Unpinning error in parallel worker

Поиск
Список
Период
Сортировка

Re: [sqlsmith] Unpinning error in parallel worker

От
Thomas Munro
Дата:
On Thu, Mar 30, 2017 at 3:50 AM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Wed, Mar 29, 2017 at 1:31 AM, Thomas Munro
> <thomas.munro@enterprisedb.com> wrote:
>> I considered whether the error message could be improved but it
>> matches the message for an existing similar case (where you try to
>> attach to an unknown handle).
>
> Ugh, OK.  I committed this, but I think this whole file needs a visit
> from the message style police.

Like this?

-- 
Thomas Munro
http://www.enterprisedb.com

Вложения

Re: [sqlsmith] Unpinning error in parallel worker

От
Robert Haas
Дата:
On Wed, Apr 5, 2017 at 3:59 AM, Thomas Munro
<thomas.munro@enterprisedb.com> wrote:
> On Thu, Mar 30, 2017 at 3:50 AM, Robert Haas <robertmhaas@gmail.com> wrote:
>> On Wed, Mar 29, 2017 at 1:31 AM, Thomas Munro
>> <thomas.munro@enterprisedb.com> wrote:
>>> I considered whether the error message could be improved but it
>>> matches the message for an existing similar case (where you try to
>>> attach to an unknown handle).
>>
>> Ugh, OK.  I committed this, but I think this whole file needs a visit
>> from the message style police.
>
> Like this?

I was thinking of maybe not creating two separate (translatable)
messages, and just using "could not attach to dynamic shared area" for
both.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company