Обсуждение: [pgsql-www] Small feature request for CF app
It would be nice if, when I'm not logged in, the CF app's "Add annotation" button became obviously inoperable, or disappeared. Right now, I won't realize that I'm not signed in (a regular occurrence, given the way a login to my community account times out), and then make an annoying error that wastes some time. I'll type in an annotation description, only to be told that I'm not logged in when I've already finished it. A minor issue, certainly, but one worth fixing. This has happened to me many times now, since I'm a big fan of using annotations. I imagine that this wouldn't be very hard to implement, since the "Subscribe" button already doesn't appear when I'm not logged in. Thanks -- Peter Geoghegan -- Sent via pgsql-www mailing list (pgsql-www@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-www
> On 16 Sep 2017, at 20:52, Peter Geoghegan <pg@bowt.ie> wrote: > > It would be nice if, when I'm not logged in, the CF app's "Add > annotation" button became obviously inoperable, or disappeared. > > Right now, I won't realize that I'm not signed in (a regular > occurrence, given the way a login to my community account times out), > and then make an annoying error that wastes some time. I'll type in an > annotation description, only to be told that I'm not logged in when > I've already finished it. Should absolutely be fixed, functionality requiring login should only be visible when logged in. > A minor issue, certainly, but one worth fixing. This has happened to > me many times now, since I'm a big fan of using annotations. I imagine > that this wouldn't be very hard to implement, since the "Subscribe" > button already doesn't appear when I'm not logged in. The attached patch should fix it, I think. cheers ./daniel -- Sent via pgsql-www mailing list (pgsql-www@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-www
Вложения
On Sat, Sep 16, 2017 at 1:07 PM, Daniel Gustafsson <daniel@yesql.se> wrote: >> A minor issue, certainly, but one worth fixing. This has happened to >> me many times now, since I'm a big fan of using annotations. I imagine >> that this wouldn't be very hard to implement, since the "Subscribe" >> button already doesn't appear when I'm not logged in. > > The attached patch should fix it, I think. That was quick. Thanks Daniel! -- Peter Geoghegan -- Sent via pgsql-www mailing list (pgsql-www@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-www
On Sat, Sep 16, 2017 at 10:07 PM, Daniel Gustafsson <daniel@yesql.se> wrote:
> On 16 Sep 2017, at 20:52, Peter Geoghegan <pg@bowt.ie> wrote:
>
> It would be nice if, when I'm not logged in, the CF app's "Add
> annotation" button became obviously inoperable, or disappeared.
>
> Right now, I won't realize that I'm not signed in (a regular
> occurrence, given the way a login to my community account times out),
> and then make an annoying error that wastes some time. I'll type in an
> annotation description, only to be told that I'm not logged in when
> I've already finished it.
Should absolutely be fixed, functionality requiring login should only be
visible when logged in.
> A minor issue, certainly, but one worth fixing. This has happened to
> me many times now, since I'm a big fan of using annotations. I imagine
> that this wouldn't be very hard to implement, since the "Subscribe"
> button already doesn't appear when I'm not logged in.
The attached patch should fix it, I think.
Pushed, thanks.