Обсуждение: [COMMITTERS] pgsql: Fix assorted portability issues in new pgbench TAP tests.

Fix assorted portability issues in new pgbench TAP tests.

* Our own version of getopt_long doesn't support abbreviation of
long options.

* It doesn't do automatic rearrangement of non-option arguments to the end,
either.

* Test was way too optimistic about the platform independence of
NaN and Infinity outputs.  I rather imagine we might have to lose
those tests altogether, but for the moment just allow case variation
and fully spelled out Infinity.

Per buildfarm.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/869aa40a27fa4908ad4112f1079bf732d1a12e13

Modified Files
--------------
src/bin/pgbench/t/001_pgbench_with_server.pl | 11 ++++-------
src/bin/pgbench/t/002_pgbench_no_server.pl   |  2 +-
2 files changed, 5 insertions(+), 8 deletions(-)


--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

> Fix assorted portability issues in new pgbench TAP tests.

Most where hard to guess without having the report. Thanks.

> * Test was way too optimistic about the platform independence of
> NaN and Infinity outputs.  I rather imagine we might have to lose
> those tests altogether, but for the moment just allow case variation
> and fully spelled out Infinity.

Yep. I've seen strange things on these. I wonder whether all test platform 
are IEEE 754 conforming.

-- 
Fabien.


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Hello,

Please find attached "blind" additional fixes for Windows & AIX.

  - more nan/inf variants
  - different message on non existing user
  - illegal vs unrecognized options

I suspect that $windows_os is not true on "bowerbird", in order to fix it 
the value of "$Config{osname}" is needed...

-- 
Fabien.
-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Fabien COELHO <coelho@cri.ensmp.fr> writes:
> Please find attached "blind" additional fixes for Windows & AIX.

>   - more nan/inf variants

I think we should just drop this.  It's not worth the trouble,
and I have no faith whatsoever that we've seen every behavior.

>   - different message on non existing user

Ditto.  It's not only not worth the trouble, it's out of scope for
pgbench tests.  A single connection-failure test case seems plenty
to me, and the no-such-database case is enough for that.

> I suspect that $windows_os is not true on "bowerbird", in order to fix it 
> the value of "$Config{osname}" is needed...

I looked at sub psql and noted that it was disassembling the $? result
without any platform-specific hacks.  So I've made command_checks_all
do likewise, and also notice crashes if any.
        regards, tom lane


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers