Обсуждение: [COMMITTERS] pgsql: Remove dedicated B-tree root-split record types.

Поиск
Список
Период
Сортировка

[COMMITTERS] pgsql: Remove dedicated B-tree root-split record types.

От
Heikki Linnakangas
Дата:
Remove dedicated B-tree root-split record types.

Since commit 40dae7ec53, which changed the way b-tree page splitting
works, there has been no difference in the handling of root, and non-root
split WAL records. We don't need to distinguish them anymore

If you're worried about the loss of debugging information, note that
usually a root split record will normally be followed by a WAL record to
create the new root page. The root page will also have the BTP_ROOT flag
set on the page itself, and there is a pointer to it from the metapage.

Author: Aleksander Alekseev
Discussion: https://www.postgresql.org/message-id/20170406122116.GA11081@e733.localdomain

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/0c504a80cf2e6f66df2cdea563e879bf4abd1629

Modified Files
--------------
src/backend/access/nbtree/nbtinsert.c |  8 +-------
src/backend/access/nbtree/nbtxlog.c   | 12 +++---------
src/backend/access/rmgrdesc/nbtdesc.c |  8 --------
src/include/access/nbtxlog.h          |  3 +--
4 files changed, 5 insertions(+), 26 deletions(-)


Re: [COMMITTERS] pgsql: Remove dedicated B-tree root-split record types.

От
Tom Lane
Дата:
Heikki Linnakangas <heikki.linnakangas@iki.fi> writes:
> Remove dedicated B-tree root-split record types.

This should have involved a WAL version (XLOG_PAGE_MAGIC) bump, no?
The new code can no longer read old WAL, so it's incompatible.

            regards, tom lane