[COMMITTERS] pgsql: Allow vacuums to report oldestxmin

Поиск
Список
Период
Сортировка
Искать

[COMMITTERS] pgsql: Allow vacuums to report oldestxmin

От:
Simon Riggs <simon@2ndQuadrant.com>
Дата:
Allow vacuums to report oldestxmin

Allow VACUUM and Autovacuum to report the oldestxmin value they
used while cleaning tables, helping to make better sense out of
the other statistics we report in various cases.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/9eb344faf54a849898d9be012ddfa8204cfeb57c

Modified Files
--------------
src/backend/commands/vacuumlazy.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)

Re: [COMMITTERS] pgsql: Allow vacuums to report oldestxmin

От:
Masahiko Sawada <sawada.mshk@gmail.com>
Дата:
Вложения:
On Fri, Mar 3, 2017 at 10:50 PM, Simon Riggs  wrote:
> Allow vacuums to report oldestxmin
>
> Allow VACUUM and Autovacuum to report the oldestxmin value they
> used while cleaning tables, helping to make better sense out of
> the other statistics we report in various cases.
>
> Branch
> ------
> master
>
> Details
> -------
> http://git.postgresql.org/pg/commitdiff/9eb344faf54a849898d9be012ddfa8204cfeb57c
>
> Modified Files
> --------------
> src/backend/commands/vacuumlazy.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
>

Should we change the example in vacuum.sgml file as well? Attached patch.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Re: [COMMITTERS] pgsql: Allow vacuums to report oldestxmin

От:
Fujii Masao <masao.fujii@gmail.com>
Дата:
On Mon, Mar 6, 2017 at 9:37 PM, Masahiko Sawada  wrote:
> On Fri, Mar 3, 2017 at 10:50 PM, Simon Riggs  wrote:
>> Allow vacuums to report oldestxmin
>>
>> Allow VACUUM and Autovacuum to report the oldestxmin value they
>> used while cleaning tables, helping to make better sense out of
>> the other statistics we report in various cases.
>>
>> Branch
>> ------
>> master
>>
>> Details
>> -------
>> http://git.postgresql.org/pg/commitdiff/9eb344faf54a849898d9be012ddfa8204cfeb57c
>>
>> Modified Files
>> --------------
>> src/backend/commands/vacuumlazy.c | 9 +++++----
>> 1 file changed, 5 insertions(+), 4 deletions(-)
>>
>>
>
> Should we change the example in vacuum.sgml file as well? Attached patch.

"tuples" in the above should be "row versions"?
We should review not only this line but also all the lines in the example
of VERBOSE output, I think.

Regards,

-- 
Fujii Masao

Re: [COMMITTERS] pgsql: Allow vacuums to report oldestxmin

От:
Masahiko Sawada <sawada.mshk@gmail.com>
Дата:
Вложения:
On Sun, Mar 26, 2017 at 1:37 AM, Fujii Masao  wrote:
> On Mon, Mar 6, 2017 at 9:37 PM, Masahiko Sawada  wrote:
>> On Fri, Mar 3, 2017 at 10:50 PM, Simon Riggs  wrote:
>>> Allow vacuums to report oldestxmin
>>>
>>> Allow VACUUM and Autovacuum to report the oldestxmin value they
>>> used while cleaning tables, helping to make better sense out of
>>> the other statistics we report in various cases.
>>>
>>> Branch
>>> ------
>>> master
>>>
>>> Details
>>> -------
>>> http://git.postgresql.org/pg/commitdiff/9eb344faf54a849898d9be012ddfa8204cfeb57c
>>>
>>> Modified Files
>>> --------------
>>> src/backend/commands/vacuumlazy.c | 9 +++++----
>>> 1 file changed, 5 insertions(+), 4 deletions(-)
>>>
>>>
>>
>> Should we change the example in vacuum.sgml file as well? Attached patch.
>
> "tuples" in the above should be "row versions"?
> We should review not only this line but also all the lines in the example
> of VERBOSE output, I think.

Right. These verbose log messages are out of date. I ran
VACUUM(VERBOSE, ANALYZE) with same scenario as current example as
possible. Attached patch updates verbose log messages.


Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Re: [COMMITTERS] pgsql: Allow vacuums to report oldestxmin

От:
Masahiko Sawada <sawada.mshk@gmail.com>
Дата:
On Sun, Mar 26, 2017 at 2:26 AM, Masahiko Sawada  wrote:
> On Sun, Mar 26, 2017 at 1:37 AM, Fujii Masao  wrote:
>> On Mon, Mar 6, 2017 at 9:37 PM, Masahiko Sawada  wrote:
>>> On Fri, Mar 3, 2017 at 10:50 PM, Simon Riggs  wrote:
>>>> Allow vacuums to report oldestxmin
>>>>
>>>> Allow VACUUM and Autovacuum to report the oldestxmin value they
>>>> used while cleaning tables, helping to make better sense out of
>>>> the other statistics we report in various cases.
>>>>
>>>> Branch
>>>> ------
>>>> master
>>>>
>>>> Details
>>>> -------
>>>> http://git.postgresql.org/pg/commitdiff/9eb344faf54a849898d9be012ddfa8204cfeb57c
>>>>
>>>> Modified Files
>>>> --------------
>>>> src/backend/commands/vacuumlazy.c | 9 +++++----
>>>> 1 file changed, 5 insertions(+), 4 deletions(-)
>>>>
>>>>
>>>
>>> Should we change the example in vacuum.sgml file as well? Attached patch.
>>
>> "tuples" in the above should be "row versions"?
>> We should review not only this line but also all the lines in the example
>> of VERBOSE output, I think.
>
> Right. These verbose log messages are out of date. I ran
> VACUUM(VERBOSE, ANALYZE) with same scenario as current example as
> possible. Attached patch updates verbose log messages.
>
>

Surprisingly the changes "tuples" -> "row versions" in vacuumlazy.c is
introduced by commit feb4f44d296b88b7f0723f4a4f3945a371276e0b in 2003.
If this patch is applied, it should back-patch to all supported
branches.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Re: [COMMITTERS] pgsql: Allow vacuums to report oldestxmin

От:
Fujii Masao <masao.fujii@gmail.com>
Дата:
On Tue, Mar 28, 2017 at 1:06 AM, Masahiko Sawada  wrote:
> On Sun, Mar 26, 2017 at 2:26 AM, Masahiko Sawada  wrote:
>> On Sun, Mar 26, 2017 at 1:37 AM, Fujii Masao  wrote:
>>> On Mon, Mar 6, 2017 at 9:37 PM, Masahiko Sawada  wrote:
>>>> On Fri, Mar 3, 2017 at 10:50 PM, Simon Riggs  wrote:
>>>>> Allow vacuums to report oldestxmin
>>>>>
>>>>> Allow VACUUM and Autovacuum to report the oldestxmin value they
>>>>> used while cleaning tables, helping to make better sense out of
>>>>> the other statistics we report in various cases.
>>>>>
>>>>> Branch
>>>>> ------
>>>>> master
>>>>>
>>>>> Details
>>>>> -------
>>>>> http://git.postgresql.org/pg/commitdiff/9eb344faf54a849898d9be012ddfa8204cfeb57c
>>>>>
>>>>> Modified Files
>>>>> --------------
>>>>> src/backend/commands/vacuumlazy.c | 9 +++++----
>>>>> 1 file changed, 5 insertions(+), 4 deletions(-)
>>>>>
>>>>>
>>>>
>>>> Should we change the example in vacuum.sgml file as well? Attached patch.
>>>
>>> "tuples" in the above should be "row versions"?
>>> We should review not only this line but also all the lines in the example
>>> of VERBOSE output, I think.
>>
>> Right. These verbose log messages are out of date. I ran
>> VACUUM(VERBOSE, ANALYZE) with same scenario as current example as
>> possible. Attached patch updates verbose log messages.
>>
>>
>
> Surprisingly the changes "tuples" -> "row versions" in vacuumlazy.c is
> introduced by commit feb4f44d296b88b7f0723f4a4f3945a371276e0b in 2003.

This is the evidence that no one cares about the details of VACUUM VERBOSE
output example. So I'm tempted to simplify the example (please see the
attached patch) instead of keeping updating the example.

> If this patch is applied, it should back-patch to all supported
> branches.

Not sure if it's worth back-patching that.

Regards,

-- 
Fujii Masao

Re: [COMMITTERS] pgsql: Allow vacuums to report oldestxmin

От:
Masahiko Sawada <sawada.mshk@gmail.com>
Дата:
On Wed, Mar 29, 2017 at 1:32 AM, Fujii Masao  wrote:
> On Tue, Mar 28, 2017 at 1:06 AM, Masahiko Sawada  wrote:
>> On Sun, Mar 26, 2017 at 2:26 AM, Masahiko Sawada  wrote:
>>> On Sun, Mar 26, 2017 at 1:37 AM, Fujii Masao  wrote:
>>>> On Mon, Mar 6, 2017 at 9:37 PM, Masahiko Sawada  wrote:
>>>>> On Fri, Mar 3, 2017 at 10:50 PM, Simon Riggs  wrote:
>>>>>> Allow vacuums to report oldestxmin
>>>>>>
>>>>>> Allow VACUUM and Autovacuum to report the oldestxmin value they
>>>>>> used while cleaning tables, helping to make better sense out of
>>>>>> the other statistics we report in various cases.
>>>>>>
>>>>>> Branch
>>>>>> ------
>>>>>> master
>>>>>>
>>>>>> Details
>>>>>> -------
>>>>>> http://git.postgresql.org/pg/commitdiff/9eb344faf54a849898d9be012ddfa8204cfeb57c
>>>>>>
>>>>>> Modified Files
>>>>>> --------------
>>>>>> src/backend/commands/vacuumlazy.c | 9 +++++----
>>>>>> 1 file changed, 5 insertions(+), 4 deletions(-)
>>>>>>
>>>>>>
>>>>>
>>>>> Should we change the example in vacuum.sgml file as well? Attached patch.
>>>>
>>>> "tuples" in the above should be "row versions"?
>>>> We should review not only this line but also all the lines in the example
>>>> of VERBOSE output, I think.
>>>
>>> Right. These verbose log messages are out of date. I ran
>>> VACUUM(VERBOSE, ANALYZE) with same scenario as current example as
>>> possible. Attached patch updates verbose log messages.
>>>
>>>
>>
>> Surprisingly the changes "tuples" -> "row versions" in vacuumlazy.c is
>> introduced by commit feb4f44d296b88b7f0723f4a4f3945a371276e0b in 2003.
>
> This is the evidence that no one cares about the details of VACUUM VERBOSE
> output example. So I'm tempted to simplify the example (please see the
> attached patch) instead of keeping updating the example.

Yes. I agree.

>
>> If this patch is applied, it should back-patch to all supported
>> branches.
>
> Not sure if it's worth back-patching that.
>
> Regards,
>
> --
> Fujii Masao

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Re: [COMMITTERS] pgsql: Allow vacuums to report oldestxmin

От:
Fujii Masao <masao.fujii@gmail.com>
Дата:
On Wed, Mar 29, 2017 at 3:31 PM, Masahiko Sawada  wrote:
> On Wed, Mar 29, 2017 at 1:32 AM, Fujii Masao  wrote:
>> On Tue, Mar 28, 2017 at 1:06 AM, Masahiko Sawada  wrote:
>>> On Sun, Mar 26, 2017 at 2:26 AM, Masahiko Sawada  wrote:
>>>> On Sun, Mar 26, 2017 at 1:37 AM, Fujii Masao  wrote:
>>>>> On Mon, Mar 6, 2017 at 9:37 PM, Masahiko Sawada  wrote:
>>>>>> On Fri, Mar 3, 2017 at 10:50 PM, Simon Riggs  wrote:
>>>>>>> Allow vacuums to report oldestxmin
>>>>>>>
>>>>>>> Allow VACUUM and Autovacuum to report the oldestxmin value they
>>>>>>> used while cleaning tables, helping to make better sense out of
>>>>>>> the other statistics we report in various cases.
>>>>>>>
>>>>>>> Branch
>>>>>>> ------
>>>>>>> master
>>>>>>>
>>>>>>> Details
>>>>>>> -------
>>>>>>> http://git.postgresql.org/pg/commitdiff/9eb344faf54a849898d9be012ddfa8204cfeb57c
>>>>>>>
>>>>>>> Modified Files
>>>>>>> --------------
>>>>>>> src/backend/commands/vacuumlazy.c | 9 +++++----
>>>>>>> 1 file changed, 5 insertions(+), 4 deletions(-)
>>>>>>>
>>>>>>>
>>>>>>
>>>>>> Should we change the example in vacuum.sgml file as well? Attached patch.
>>>>>
>>>>> "tuples" in the above should be "row versions"?
>>>>> We should review not only this line but also all the lines in the example
>>>>> of VERBOSE output, I think.
>>>>
>>>> Right. These verbose log messages are out of date. I ran
>>>> VACUUM(VERBOSE, ANALYZE) with same scenario as current example as
>>>> possible. Attached patch updates verbose log messages.
>>>>
>>>>
>>>
>>> Surprisingly the changes "tuples" -> "row versions" in vacuumlazy.c is
>>> introduced by commit feb4f44d296b88b7f0723f4a4f3945a371276e0b in 2003.
>>
>> This is the evidence that no one cares about the details of VACUUM VERBOSE
>> output example. So I'm tempted to simplify the example (please see the
>> attached patch) instead of keeping updating the example.
>
> Yes. I agree.

Pushed. I back-patched to all supported versions according to
Alvaro's comment upthread.

Regards,

-- 
Fujii Masao

FAQ