Обсуждение: [pgadmin-hackers] PATCH: Dialogue control buttons should be consistent (pgAdmin4)
[pgadmin-hackers] PATCH: Dialogue control buttons should be consistent (pgAdmin4)
От
Murtuza Zabuawala
Дата:
Hi,
PFA patch to fix the issue where some dialogue control buttons were not consistent with others dialogs.
RM#1364
Patch fixes,
1) Preferences: Close, Maximise, Pin
- Removed Pin button
2) Wizards: Close
- Added Maximise button, which is can used with 'show_header_maximize_btn' option.
3) Properties: Close
- N/A, As this is custom wcDocker panel not alertify dialog.
- N/A, As this is custom wcDocker panel not alertify dialog.
4) User manager: Maximise
- We can't have close button in User Manager as data validation was main requirement, If user clicks on right top close button while having dirty data in dialog then we can't stop alertify dialog from closing even with confirm prompt hence we have removed the button.
--
Regards,
Вложения
Thanks, patch applied.
On Friday, January 6, 2017, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Friday, January 6, 2017, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,PFA patch to fix the issue where some dialogue control buttons were not consistent with others dialogs.RM#1364Patch fixes,1) Preferences: Close, Maximise, Pin- Removed Pin button2) Wizards: Close- Added Maximise button, which is can used with 'show_header_maximize_btn' option.3) Properties: Close
- N/A, As this is custom wcDocker panel not alertify dialog.4) User manager: Maximise- We can't have close button in User Manager as data validation was main requirement, If user clicks on right top close button while having dirty data in dialog then we can't stop alertify dialog from closing even with confirm prompt hence we have removed the button.--Regards,
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company