Обсуждение: [pgadmin-hackers] PATCH: Enhancement in SQL Field Backform control (pgAdmin4)
[pgadmin-hackers] PATCH: Enhancement in SQL Field Backform control (pgAdmin4)
От
Murtuza Zabuawala
Дата:
Hi,
PFA minor patch to allow SQL field Backform Control to wrap code.
There is no open RM for this, it's just a small enhancement to control (PFA screenshot for reference).
--
Regards,
Вложения
On Fri, Dec 16, 2016 at 9:17 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: > Hi, > > PFA minor patch to allow SQL field Backform Control to wrap code. > There is no open RM for this, it's just a small enhancement to control (PFA > screenshot for reference). Wouldn't this be better as an option under File->Preferences->SQL Editor->Options affecting all SQL fields (including the query tool)? It seems like it should be consistent, and optional. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: [pgadmin-hackers] PATCH: Enhancement in SQL Field Backformcontrol (pgAdmin4)
От
Murtuza Zabuawala
Дата:
Hi Dave,
PFA updated patch with suggested changes, I only thought of SqlFieldControl but yes we can use the same configuration everywhere.
Please review.
--
Regards,
On Fri, Dec 16, 2016 at 6:38 PM, Dave Page <dpage@pgadmin.org> wrote:
On Fri, Dec 16, 2016 at 9:17 AM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
> Hi,
>
> PFA minor patch to allow SQL field Backform Control to wrap code.
> There is no open RM for this, it's just a small enhancement to control (PFA
> screenshot for reference).
Wouldn't this be better as an option under File->Preferences->SQL
Editor->Options affecting all SQL fields (including the query tool)?
It seems like it should be consistent, and optional.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Вложения
Thanks, patch applied. On Fri, Dec 16, 2016 at 2:29 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: > Hi Dave, > > PFA updated patch with suggested changes, I only thought of SqlFieldControl > but yes we can use the same configuration everywhere. > > Please review. > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Fri, Dec 16, 2016 at 6:38 PM, Dave Page <dpage@pgadmin.org> wrote: >> >> On Fri, Dec 16, 2016 at 9:17 AM, Murtuza Zabuawala >> <murtuza.zabuawala@enterprisedb.com> wrote: >> > Hi, >> > >> > PFA minor patch to allow SQL field Backform Control to wrap code. >> > There is no open RM for this, it's just a small enhancement to control >> > (PFA >> > screenshot for reference). >> >> Wouldn't this be better as an option under File->Preferences->SQL >> Editor->Options affecting all SQL fields (including the query tool)? >> It seems like it should be consistent, and optional. >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company