Обсуждение: pgsql: Log the creation of an init fork unconditionally.

Поиск
Список
Период
Сортировка

pgsql: Log the creation of an init fork unconditionally.

От
Robert Haas
Дата:
Log the creation of an init fork unconditionally.

Previously, it was thought that this only needed to be done for the
benefit of possible standbys, so wal_level = minimal skipped it.
But that's not safe, because during crash recovery we might replay
XLOG_DBASE_CREATE or XLOG_TBLSPC_CREATE record which recursively
removes the directory that contains the new init fork.  So log it
always.

The user-visible effect of this bug is that if you create a database
or tablespace, then create an unlogged table, then crash without
checkpointing, then restart, accessing the table will fail, because
the it won't have been properly reset.  This commit fixes that.

Michael Paquier, per a report from Konstantin Knizhnik.  Wording of
the comments per a suggestion from me.

Branch
------
REL9_3_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/8e403f2151995595a8f24c6c90adc331a8353289

Modified Files
--------------
src/backend/access/nbtree/nbtree.c    | 13 +++++++++----
src/backend/access/spgist/spginsert.c | 23 +++++++++++++----------
src/backend/catalog/heap.c            | 13 +++++++------
3 files changed, 29 insertions(+), 20 deletions(-)