Обсуждение: Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

Поиск
Список
Период
Сортировка

Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

От
Magnus Hagander
Дата:
This seems to have broken our website build a bit. If you check https://www.postgresql.org/docs/devel/static/index.html, you'll notice a bunch of bad characters.

AFAICT this is because the output is now UTF8 and it used to be LATIN1. The current output actually has it in the html tags that it's utf8,but since the old one had no tags specifying it's encoding we hardcoded it to LATIN1.

I assume we shall expect it to always be UTF8 from now on, and just find a way for the docs loader script for the website to properly detect when we switched over? Probably by just looking for that specific <?xml tag on the first line.

Is this change something that might break something else, though?

//Magnus


On Wed, Nov 16, 2016 at 8:06 AM, Peter Eisentraut <peter_e@gmx.net> wrote:
Build HTML documentation using XSLT stylesheets by default

The old DSSSL build is still available for a while using the make target
"oldhtml".

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/e36ddab11735052841b4eff96642187ec9a8a7bc

Modified Files
--------------
doc/src/sgml/Makefile       |  8 ++++----
doc/src/sgml/stylesheet.css | 50 +++++++++++++++++----------------------------
2 files changed, 23 insertions(+), 35 deletions(-)


--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

От
Peter Eisentraut
Дата:
On 11/16/16 1:38 AM, Magnus Hagander wrote:
> AFAICT this is because the output is now UTF8 and it used to be LATIN1.
> The current output actually has it in the html tags that it's utf8,but
> since the old one had no tags specifying it's encoding we hardcoded it
> to LATIN1.

The old output has this:

<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=ISO-8859-1">

This has always been the case, AFAICT.

Btw., shouldn't the output web site pages have encoding declarations?

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

От
Magnus Hagander
Дата:
On Wed, Nov 16, 2016 at 3:02 PM, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:
On 11/16/16 1:38 AM, Magnus Hagander wrote:
> AFAICT this is because the output is now UTF8 and it used to be LATIN1.
> The current output actually has it in the html tags that it's utf8,but
> since the old one had no tags specifying it's encoding we hardcoded it
> to LATIN1.

The old output has this:

<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=ISO-8859-1">

This has always been the case, AFAICT.

Oh, it's there. It's just not on one line and not at the beginning, so I misssed it :)
 
Btw., shouldn't the output web site pages have encoding declarations?

That gets sent in the http header, doesn't it? 

--

Re: Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

От
Peter Eisentraut
Дата:
On 11/16/16 6:09 AM, Magnus Hagander wrote:
>     Btw., shouldn't the output web site pages have encoding declarations?
> 
> That gets sent in the http header, doesn't it? 

That's probably alright, but it would be nicer if the documents were
self-contained.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services