Обсуждение: Tweak cost_merge_append to reflect 7a2fe9bd?

Поиск
Список
Период
Сортировка

Tweak cost_merge_append to reflect 7a2fe9bd?

От
Thomas Munro
Дата:
Hi

As noted in a nearby review of some similar code[1], commit 7a2fe9bd
made merge append very slightly more efficient, but nobody told
cost_merge_append about the change.  I doubt it makes much difference
to the final cost in practice but I figured it might be worth
correcting the comment.  Does this make sense?

[1] https://www.postgresql.org/message-id/CAEepm%3D3o9um4pi0EphOGD7u2f862hX%2BBhwD5zko-TAk_Qj1JeQ%40mail.gmail.com

--
Thomas Munro
http://www.enterprisedb.com

Вложения

Re: Tweak cost_merge_append to reflect 7a2fe9bd?

От
Tom Lane
Дата:
Thomas Munro <thomas.munro@enterprisedb.com> writes:
> As noted in a nearby review of some similar code[1], commit 7a2fe9bd
> made merge append very slightly more efficient, but nobody told
> cost_merge_append about the change.  I doubt it makes much difference
> to the final cost in practice but I figured it might be worth
> correcting the comment.  Does this make sense?

Agreed, pushed.
        regards, tom lane