Обсуждение: Unused variable in postgres_fdw/deparse.c

Hello, compiler complains about unused variable during build
postgres_fdw without assertions (!--enable-cassert).

deparse.c: In function ‘deparseFromExpr’:
deparse.c:1029:14: warning: unused variable ‘foreignrel’ [-Wunused-variable] RelOptInfo *foreignrel =
context->foreignrel;            ^~~~~~~~~~
 

The attched patch removes it and moves into the assertion below it.

regards,

diff --git a/contrib/postgres_fdw/deparse.c b/contrib/postgres_fdw/deparse.c
index 8da8c11..450693a 100644
--- a/contrib/postgres_fdw/deparse.c
+++ b/contrib/postgres_fdw/deparse.c
@@ -1026,11 +1026,10 @@ static voiddeparseFromExpr(List *quals, deparse_expr_cxt *context){    StringInfo    buf =
context->buf;
-    RelOptInfo *foreignrel = context->foreignrel;    RelOptInfo *scanrel = context->scanrel;    /* For upper
relations,scanrel must be either a joinrel or a baserel */
 
-    Assert(foreignrel->reloptkind != RELOPT_UPPER_REL ||
+    Assert(context->foreignrel->reloptkind != RELOPT_UPPER_REL ||           scanrel->reloptkind == RELOPT_JOINREL ||
       scanrel->reloptkind == RELOPT_BASEREL); 

On Wed, Oct 26, 2016 at 6:19 AM, Kyotaro HORIGUCHI
<horiguchi.kyotaro@lab.ntt.co.jp> wrote:
> Hello, compiler complains about unused variable during build
> postgres_fdw without assertions (!--enable-cassert).
>
> deparse.c: In function ‘deparseFromExpr’:
> deparse.c:1029:14: warning: unused variable ‘foreignrel’ [-Wunused-variable]
>   RelOptInfo *foreignrel = context->foreignrel;
>               ^~~~~~~~~~
>
> The attched patch removes it and moves into the assertion below it.
>

Thanks for the patch and sorry for missing this in the review. I

The patch applies but seems to have a trailing white space.
patch -p1 < /mnt/hgfs/tmp/postgre_fdw_delete_unused_var.patch
(Stripping trailing CRs from patch.)
patching file contrib/postgres_fdw/deparse.c
But that's removed my "patch" command.

It compiles cleanly and make check in contrib/postgres_fdw does not
show any failure.

--
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company

Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp> writes:
> Hello, compiler complains about unused variable during build
> postgres_fdw without assertions (!--enable-cassert).
> The attched patch removes it and moves into the assertion below it.

Pushed, thanks.
        regards, tom lane

Hi,

At Wed, 26 Oct 2016 11:00:17 +0530, Ashutosh Bapat <ashutosh.bapat@enterprisedb.com> wrote in
<CAFjFpRcFoBn0cd1hMueYtkaL+x_KcBD4kJcuvh4jqKtbviCvDw@mail.gmail.com>
> On Wed, Oct 26, 2016 at 6:19 AM, Kyotaro HORIGUCHI
> <horiguchi.kyotaro@lab.ntt.co.jp> wrote:
> Thanks for the patch and sorry for missing this in the review. I
> 
> The patch applies but seems to have a trailing white space.

Oops. My 'git commit' has a hook to warn such mistakes but it is
just made by 'git diff'. Automatic measure made me forget to keep
alert:p

> patch -p1 < /mnt/hgfs/tmp/postgre_fdw_delete_unused_var.patch
> (Stripping trailing CRs from patch.)
> patching file contrib/postgres_fdw/deparse.c
> But that's removed my "patch" command.
> 
> It compiles cleanly and make check in contrib/postgres_fdw does not
> show any failure.

Thanks for confirmation.

regards,

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

Thank you.

At Wed, 26 Oct 2016 10:20:28 -0400, Tom Lane <tgl@sss.pgh.pa.us> wrote in <17387.1477491628@sss.pgh.pa.us>
> Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp> writes:
> > Hello, compiler complains about unused variable during build
> > postgres_fdw without assertions (!--enable-cassert).
> > The attched patch removes it and moves into the assertion below it.
> 
> Pushed, thanks.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center