Обсуждение: pgsql: Make TAP test suites to work, when @INC does not contain current
Make TAP test suites to work, when @INC does not contain current dir. Recent Perl and/or new Linux distributions are starting to remove "." from the @INC list by default. That breaks pg_rewind and ssl test suites, which use helper perl modules that reside in the same directory. To fix, add the current source directory explicitly to prove's include dir. The vcregress.pl script probably also needs something like this, but I wasn't able to remove '.' from @INC on Windows to test this, and don't want to try doing that blindly. Discussion: <20160908204529.flg6nivjuwp5vaoy@alap3.anarazel.de> Branch ------ master Details ------- http://git.postgresql.org/pg/commitdiff/d668b03378c28b927d0ba458681ca1b4c1e18e53 Modified Files -------------- src/Makefile.global.in | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Hi, On 2016-10-07 18:50:27 +0000, Heikki Linnakangas wrote: > Make TAP test suites to work, when @INC does not contain current dir. > > Recent Perl and/or new Linux distributions are starting to remove "." from > the @INC list by default. That breaks pg_rewind and ssl test suites, which > use helper perl modules that reside in the same directory. To fix, add the > current source directory explicitly to prove's include dir. > > The vcregress.pl script probably also needs something like this, but I > wasn't able to remove '.' from @INC on Windows to test this, and don't want > to try doing that blindly. > > Discussion: <20160908204529.flg6nivjuwp5vaoy@alap3.anarazel.de> > > Branch > ------ > master Don't we need to backpatch this? Andres
Re: pgsql: Make TAP test suites to work, when @INC does not contain current
От
Heikki Linnakangas
Дата:
On 10/07/2016 09:55 PM, Andres Freund wrote: > Hi, > > On 2016-10-07 18:50:27 +0000, Heikki Linnakangas wrote: >> Make TAP test suites to work, when @INC does not contain current dir. >> >> Recent Perl and/or new Linux distributions are starting to remove "." from >> the @INC list by default. That breaks pg_rewind and ssl test suites, which >> use helper perl modules that reside in the same directory. To fix, add the >> current source directory explicitly to prove's include dir. >> >> The vcregress.pl script probably also needs something like this, but I >> wasn't able to remove '.' from @INC on Windows to test this, and don't want >> to try doing that blindly. >> >> Discussion: <20160908204529.flg6nivjuwp5vaoy@alap3.anarazel.de> >> >> Branch >> ------ >> master > > Don't we need to backpatch this? Yeah, I just did, just wasn't part of the same "git push". - Heikki