Обсуждение: Mention to pg_backup in pg_dump.c
Hi all, I just bumped into the following thing in pg_dump.c: /* Set default options based on progname */ if (strcmp(progname,"pg_backup") == 0) format = "c"; As far as I can see this comes from e8f69be0 dated of 2000. Couldn't this be removed? I have never seen traces of pg_backup in the code. Regards, -- Michael
Michael Paquier <michael.paquier@gmail.com> writes: > I just bumped into the following thing in pg_dump.c: > /* Set default options based on progname */ > if (strcmp(progname, "pg_backup") == 0) > format = "c"; > As far as I can see this comes from e8f69be0 dated of 2000. Couldn't > this be removed? I have never seen traces of pg_backup in the code. Looks dead to me too --- deleted. regards, tom lane
On Fri, Oct 14, 2016 at 5:08 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote: > Michael Paquier <michael.paquier@gmail.com> writes: >> I just bumped into the following thing in pg_dump.c: >> /* Set default options based on progname */ >> if (strcmp(progname, "pg_backup") == 0) >> format = "c"; >> As far as I can see this comes from e8f69be0 dated of 2000. Couldn't >> this be removed? I have never seen traces of pg_backup in the code. > > Looks dead to me too --- deleted. Thanks. -- Michael