Обсуждение: PATCH: To fix the issue displaying composite result types in debugger (pgAdmin4)

Поиск
Список
Период
Сортировка

PATCH: To fix the issue displaying composite result types in debugger (pgAdmin4)

От
Murtuza Zabuawala
Дата:
Hi,

PFA patch to fix the issue in debugger where we were not displaying result properly in result tab for composite types.
RM#1662
 
@Neel,
Would you please review the patch?

Issue:
Column name key was hardcoded in dict causing overwriting other columns.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Вложения

Re: PATCH: To fix the issue displaying composite result types in debugger (pgAdmin4)

От
Neel Patel
Дата:
Hi Murtuza,

Sure. I will review it.

Thanks,
Neel Patel

On Tue, Sep 20, 2016 at 3:16 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to fix the issue in debugger where we were not displaying result properly in result tab for composite types.
RM#1662
 
@Neel,
Would you please review the patch?

Issue:
Column name key was hardcoded in dict causing overwriting other columns.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: PATCH: To fix the issue displaying composite result types in debugger (pgAdmin4)

От
Dave Page
Дата:
Thanks - applied.

On Tue, Sep 20, 2016 at 10:46 AM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
> Hi,
>
> PFA patch to fix the issue in debugger where we were not displaying result
> properly in result tab for composite types.
> RM#1662
>
> @Neel,
> Would you please review the patch?
>
> Issue:
> Column name key was hardcoded in dict causing overwriting other columns.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company