Обсуждение: fix for Makefile.shlib multiply defined target
The attached patch fixes a problem with multiple target definitions that
give rise to warnings like this:
../../src/Makefile.shlib:327: warning: overriding commands for target `libtsearch2.a'
../../src/Makefile.shlib:262: warning: ignoring old commands for target `libtsearch2.a'
cheers
andrew
Index: src/Makefile.shlib
===================================================================
RCS file: /home/cvsmirror/pgsql/src/Makefile.shlib,v
retrieving revision 1.86
diff -c -r1.86 Makefile.shlib
*** src/Makefile.shlib 16 Oct 2004 03:26:43 -0000 1.86
--- src/Makefile.shlib 21 Oct 2004 15:55:12 -0000
***************
*** 220,229 ****
--- 220,231 ----
shlib = $(NAME)$(DLSUFFIX)
# needed for /contrib modules, not sure why
SHLIB_LINK += -lpgport
+ haslibarule = yes
endif
ifeq ($(PORTNAME), win32)
shlib = lib$(NAME)$(DLSUFFIX)
+ haslibarule = yes
endif
ifeq ($(PORTNAME), beos)
***************
*** 257,262 ****
--- 259,265 ----
MK_NO_LORDER := true
endif
+ ifndef haslibarule
lib$(NAME).a: $(OBJS)
ifdef MK_NO_LORDER
$(LINK.static) $@ $^
***************
*** 264,269 ****
--- 267,273 ----
$(LINK.static) $@ `$(LORDER) $^ | tsort`
endif
$(RANLIB) $@
+ endif #haslibarule
ifeq ($(enable_shared), yes)
I am told this patch is no longer required. --------------------------------------------------------------------------- Andrew Dunstan wrote: > > The attached patch fixes a problem with multiple target definitions that > give rise to warnings like this: > > ../../src/Makefile.shlib:327: warning: overriding commands for target `libtsearch2.a' > ../../src/Makefile.shlib:262: warning: ignoring old commands for target `libtsearch2.a' > > cheers > > andrew > > > > ---------------------------(end of broadcast)--------------------------- > TIP 8: explain analyze is your friend -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073
Well, one of us is confused at least. I am still seeing these warnings. cheers andrew Bruce Momjian wrote: >I am told this patch is no longer required. > >--------------------------------------------------------------------------- > >Andrew Dunstan wrote: > > >>The attached patch fixes a problem with multiple target definitions that >>give rise to warnings like this: >> >>../../src/Makefile.shlib:327: warning: overriding commands for target `libtsearch2.a' >>../../src/Makefile.shlib:262: warning: ignoring old commands for target `libtsearch2.a' >> >> >> >