Обсуждение: Re: [HACKERS] Open Items
> o fix shared memory on Win2k terminal server > > We might be able to just mark this as not supported. I have attached a patch that I think fixes this. The problem I saw and fixed is, that the shmem created in a terminal services client is not visible to the console (or services.msc). It was necessary to differenciate OS versions, this might be better put elsewhere. I think in addition the system global name "sharemem.1" should be made more pg specific, like "PostgreSQL.1". I have not done this since a new compile would not detect a running old beta. But now would be the time (or never). Andreas
Вложения
Agreed on the memory name change and I will do it when I apply the
patch.
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.
---------------------------------------------------------------------------
Zeugswetter Andreas DAZ SD wrote:
>
> > o fix shared memory on Win2k terminal server
> >
> > We might be able to just mark this as not supported.
>
> I have attached a patch that I think fixes this. The problem I saw
> and fixed is, that the shmem created in a terminal services client is not
> visible to the console (or services.msc).
>
> It was necessary to differenciate OS versions, this might be better put
> elsewhere.
>
> I think in addition the system global name "sharemem.1" should be made more
> pg specific, like "PostgreSQL.1". I have not done this since a new compile
> would not detect a running old beta. But now would be the time (or never).
>
> Andreas
Content-Description: shmem.win32.patch
[ Attachment, skipping... ]
>
> ---------------------------(end of broadcast)---------------------------
> TIP 7: don't forget to increase your free space map settings
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
Where are we on this patch? --------------------------------------------------------------------------- Zeugswetter Andreas DAZ SD wrote: > > > o fix shared memory on Win2k terminal server > > > > We might be able to just mark this as not supported. > > I have attached a patch that I think fixes this. The problem I saw > and fixed is, that the shmem created in a terminal services client is not > visible to the console (or services.msc). > > It was necessary to differenciate OS versions, this might be better put > elsewhere. > > I think in addition the system global name "sharemem.1" should be made more > pg specific, like "PostgreSQL.1". I have not done this since a new compile > would not detect a running old beta. But now would be the time (or never). > > Andreas Content-Description: shmem.win32.patch [ Attachment, skipping... ] > > ---------------------------(end of broadcast)--------------------------- > TIP 7: don't forget to increase your free space map settings -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073
Zeugswetter Andreas DAZ SD wrote: > I think in addition the system global name "sharemem.1" should be made more > pg specific, like "PostgreSQL.1". I have not done this since a new compile > would not detect a running old beta. But now would be the time (or never). Change made and attached. I assume there are other ways we detect an active backend on Windows and that shared memory name is only one of them. I do think we need this fix before we put out a final release so the next beta is the best time to do it. -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073 Index: src/backend/port/win32/shmem.c =================================================================== RCS file: /cvsroot/pgsql/src/backend/port/win32/shmem.c,v retrieving revision 1.8 diff -c -c -r1.8 shmem.c *** src/backend/port/win32/shmem.c 29 Aug 2004 05:06:46 -0000 1.8 --- src/backend/port/win32/shmem.c 12 Nov 2004 16:53:28 -0000 *************** *** 89,95 **** DWORD dwRet; s_segsize = size; ! sprintf(szShareMem, "sharemem.%d", memKey); if (flag & IPC_CREAT) { --- 89,95 ---- DWORD dwRet; s_segsize = size; ! sprintf(szShareMem, "PostgreSQL.%d", memKey); if (flag & IPC_CREAT) {
I am going to discard these emails. We haven't solve the Win32 terminal server problem and I think it needs to be moved to the TODO list instead. --------------------------------------------------------------------------- Zeugswetter Andreas DAZ SD wrote: > > > o fix shared memory on Win2k terminal server > > > > We might be able to just mark this as not supported. > > I have attached a patch that I think fixes this. The problem I saw > and fixed is, that the shmem created in a terminal services client is not > visible to the console (or services.msc). > > It was necessary to differenciate OS versions, this might be better put > elsewhere. > > I think in addition the system global name "sharemem.1" should be made more > pg specific, like "PostgreSQL.1". I have not done this since a new compile > would not detect a running old beta. But now would be the time (or never). > > Andreas Content-Description: shmem.win32.patch [ Attachment, skipping... ] > > ---------------------------(end of broadcast)--------------------------- > TIP 7: don't forget to increase your free space map settings -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073