Обсуждение: note on dropped columns in pg_attribute

I didn't see it documented anywhere that a 0 in attypid of pg_attribute,
and given the note on the need to match pg_type lest failure seems to
warrant the mention.

Robert Treat
--
Build A Brighter Lamp :: Linux Apache {middleware} PostgreSQL

Robert Treat writes:

> I didn't see it documented anywhere that a 0 in attypid of pg_attribute,
> and given the note on the need to match pg_type lest failure seems to
> warrant the mention.

A column is dropped if and only if attisdropped is true.

--
Peter Eisentraut   peter_e@gmx.net

Peter Eisentraut <peter_e@gmx.net> writes:
> Robert Treat writes:
>> I didn't see it documented anywhere that a 0 in attypid of pg_attribute,
>> and given the note on the need to match pg_type lest failure seems to
>> warrant the mention.

> A column is dropped if and only if attisdropped is true.

Yes.  If we're going to add something to pg_attribute.h, it ought to say
that atttypid is *undefined* in a dropped column.  The last thing we
need is people testing it instead of attisdropped.

Also, any such documentation addition should go into catalogs.sgml not
only the .h file.

BTW, the rationale for the behavior Robert noticed is explained in heap.c:

    /*
     * Set the type OID to invalid.  A dropped attribute's type link
     * cannot be relied on (once the attribute is dropped, the type might
     * be too). Fortunately we do not need the type row --- the only
     * really essential information is the type's typlen and typalign,
     * which are preserved in the attribute's attlen and attalign.  We set
     * atttypid to zero here as a means of catching code that incorrectly
     * expects it to be valid.
     */
    attStruct->atttypid = InvalidOid;


            regards, tom lane

On Friday 05 September 2003 16:24, Peter Eisentraut wrote:
> Robert Treat writes:
> > I didn't see it documented anywhere that a 0 in attypid of pg_attribute,
> > and given the note on the need to match pg_type lest failure seems to
> > warrant the mention.
>
> A column is dropped if and only if attisdropped is true.

Right. I didn't mean to imply otherwise.  That first line should have read  "I
didn't see it documented anywhere that a 0 in attypid of pg_attribute is OK
with dropped columns".  My only point was that in the notes it says that
attypid is the OID in pg_type, and that information in that table must match
information in this table else PostgreSQL will fail.  However that's not
neccessarily true for dropped columns where there is no match cause attypid
will be 0.  Are there other cases where it can be set to 0?

Robert Treat
--
Build A Brighter Lamp :: Linux Apache {middleware} PostgreSQL