Обсуждение: 7.4 patch for cube to handle extra_float_digits

This is a patch to make cube output work like double precision output
with regard to the extra_float_digits setting.

Bruno Wolff III <bruno@wolff.to> writes:
> + extern int    extra_float_digits; /* Added to DBL_DIG */

Please include the appropriate header file (here utils/builtins.h),
instead of sprinkling the code with random extern declarations.

Otherwise this seems like a fine idea...

            regards, tom lane

On Sun, Nov 17, 2002 at 02:43:51 -0500,
  Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Bruno Wolff III <bruno@wolff.to> writes:
> > + extern int    extra_float_digits; /* Added to DBL_DIG */
>
> Please include the appropriate header file (here utils/builtins.h),
> instead of sprinkling the code with random extern declarations.

Since builtins.h was already included, I just deleted the extern
statement (and accompaning comments).

A revised patch is attached.

Your patch has been added to the PostgreSQL unapplied patches list at:

    http://momjian.postgresql.org/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

---------------------------------------------------------------------------


Bruno Wolff III wrote:
> On Sun, Nov 17, 2002 at 02:43:51 -0500,
>   Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > Bruno Wolff III <bruno@wolff.to> writes:
> > > + extern int    extra_float_digits; /* Added to DBL_DIG */
> >
> > Please include the appropriate header file (here utils/builtins.h),
> > instead of sprinkling the code with random extern declarations.
>
> Since builtins.h was already included, I just deleted the extern
> statement (and accompaning comments).
>
> A revised patch is attached.

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Patch applied.  Thanks.

---------------------------------------------------------------------------


Bruno Wolff III wrote:
> On Sun, Nov 17, 2002 at 02:43:51 -0500,
>   Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > Bruno Wolff III <bruno@wolff.to> writes:
> > > + extern int    extra_float_digits; /* Added to DBL_DIG */
> >
> > Please include the appropriate header file (here utils/builtins.h),
> > instead of sprinkling the code with random extern declarations.
>
> Since builtins.h was already included, I just deleted the extern
> statement (and accompaning comments).
>
> A revised patch is attached.

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073