Обсуждение: TOAST index naming consistency

The indexes on most system catalogs are named with the suffix "_index";
not so with TOAST table indexes, which use "_idx". This trivial patch
changes TOAST table index names to use the "_index" suffix for
consistency.

Cheers,

Neil

--
Neil Conway <neilconway@rogers.com>
PGP Key ID: DB3C29FC

Your patch has been added to the PostgreSQL unapplied patches list at:

    http://candle.pha.pa.us/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

---------------------------------------------------------------------------


Neil Conway wrote:
> The indexes on most system catalogs are named with the suffix "_index";
> not so with TOAST table indexes, which use "_idx". This trivial patch
> changes TOAST table index names to use the "_index" suffix for
> consistency.
>
> Cheers,
>
> Neil
>
> --
> Neil Conway <neilconway@rogers.com>
> PGP Key ID: DB3C29FC

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/users-lounge/docs/faq.html

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

> Neil Conway wrote:
>> The indexes on most system catalogs are named with the suffix "_index";
>> not so with TOAST table indexes, which use "_idx". This trivial patch
>> changes TOAST table index names to use the "_index" suffix for
>> consistency.

Has any thought been given to what this might break?

            regards, tom lane

Tom Lane wrote:
> > Neil Conway wrote:
> >> The indexes on most system catalogs are named with the suffix "_index";
> >> not so with TOAST table indexes, which use "_idx". This trivial patch
> >> changes TOAST table index names to use the "_index" suffix for
> >> consistency.
>
> Has any thought been given to what this might break?

My assumption was that TOAST was pretty much a black box to anything
outside the backend, especially its indexes.  If there are issues, would
someone let us know.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Patch applied.  Thanks.

---------------------------------------------------------------------------


Neil Conway wrote:
> The indexes on most system catalogs are named with the suffix "_index";
> not so with TOAST table indexes, which use "_idx". This trivial patch
> changes TOAST table index names to use the "_index" suffix for
> consistency.
>
> Cheers,
>
> Neil
>
> --
> Neil Conway <neilconway@rogers.com>
> PGP Key ID: DB3C29FC

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/users-lounge/docs/faq.html

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026