Обсуждение: patch: support older junit versions

Поиск
Список
Период
Сортировка

patch: support older junit versions

От
Oliver Jowett
Дата:
My version of junit (3.7) doesn't have assertFalse. ArrayTest uses it in
a couple of places. This patch changes assertFalse(condition) to
assertTrue(!condition).

-O
Index: org/postgresql/test/jdbc2/ArrayTest.java
===================================================================
RCS file: /usr/local/cvsroot/pgjdbc/pgjdbc/org/postgresql/test/jdbc2/ArrayTest.java,v
retrieving revision 1.1
diff -c -r1.1 ArrayTest.java
*** org/postgresql/test/jdbc2/ArrayTest.java    15 Jul 2004 10:10:30 -0000    1.1
--- org/postgresql/test/jdbc2/ArrayTest.java    19 Jul 2004 23:45:26 -0000
***************
*** 81,87 ****
          assertTrue(arrrs.next());
          assertEquals(3,arrrs.getInt(1));
          assertEquals(3,arrrs.getInt(2));
!         assertFalse(arrrs.next());
          assertTrue(arrrs.previous());
          assertEquals(3,arrrs.getInt(2));
          arrrs.first();
--- 81,87 ----
          assertTrue(arrrs.next());
          assertEquals(3,arrrs.getInt(1));
          assertEquals(3,arrrs.getInt(2));
!         assertTrue(!arrrs.next());
          assertTrue(arrrs.previous());
          assertEquals(3,arrrs.getInt(2));
          arrrs.first();
***************
*** 106,112 ****
          assertTrue(arrrs.next());
          assertEquals(3, arrrs.getInt(1));
          assertEquals("fa\"b", arrrs.getString(2));
!         assertFalse(arrrs.next());
          arrrs.close();

          rs.close();
--- 106,112 ----
          assertTrue(arrrs.next());
          assertEquals(3, arrrs.getInt(1));
          assertEquals("fa\"b", arrrs.getString(2));
!         assertTrue(!arrrs.next());
          arrrs.close();

          rs.close();

Re: patch: support older junit versions

От
Kris Jurka
Дата:

On Tue, 20 Jul 2004, Oliver Jowett wrote:

> My version of junit (3.7) doesn't have assertFalse. ArrayTest uses it in
> a couple of places. This patch changes assertFalse(condition) to
> assertTrue(!condition).
>

Applied.

Kris Jurka