Обсуждение: Fw: Can't update rows in tables qualified with schema names

Поиск
Список
Период
Сортировка

Fw: Can't update rows in tables qualified with schema names

От
"Paul Sorenson"
Дата:
I sent this to the list a few days ago and it hasn't popped up yet - if you
get it twice please accept my apologies.

----- Original Message -----
From: "Paul Sorenson" <pauls@classware.com.au>
To: "postgresql jdbc" <pgsql-jdbc@postgresql.org>
Sent: Saturday, March 01, 2003 11:27 AM
Subject: Re: [JDBC] Can't update rows in tables qualified with schema names


> Try #2 (and 20 pushups)...
>
> I collapsed my spaces to tabs too - hope you guys have yours set to 4.
>
> ----- Original Message -----
> From: "Barry Lind" <blind@xythos.com>
> To: "Paul Sorenson" <pauls@classware.com.au>
> Sent: Saturday, March 01, 2003 3:57 AM
> Subject: Re: [JDBC] Can't update rows in tables qualified with schema
names
>
>
> > Paul,
> >
> > Thanks for the patch.  There are a couple of issues with it that I would
> > like to mention:
> >
> > 1) It doesn't correctly handle this case:  schema."Dot.Table"  you
> > return: Table"
> >
> > 2) It doesn't completely fix the original bug report.  The proper fix
> > would be to get both the schema and tablename from the input and pass
> > both to the getPrimaryKeys() method.  Your patch just ignores the schema
> > which is incorrect if you happen to have multiple tables with the same
> > name in different schemas.
> >
> > thanks,
> > --Barry
>

Вложения

Re: Fw: Can't update rows in tables qualified with schema

От
Barry Lind
Дата:
Paul,

Patch looks good.  I will apply later today.

thanks,
--Barry


Paul Sorenson wrote:
> I sent this to the list a few days ago and it hasn't popped up yet - if you
> get it twice please accept my apologies.
>
> ----- Original Message -----
> From: "Paul Sorenson" <pauls@classware.com.au>
> To: "postgresql jdbc" <pgsql-jdbc@postgresql.org>
> Sent: Saturday, March 01, 2003 11:27 AM
> Subject: Re: [JDBC] Can't update rows in tables qualified with schema names
>
>
>
>>Try #2 (and 20 pushups)...
>>
>>I collapsed my spaces to tabs too - hope you guys have yours set to 4.
>>
>>----- Original Message -----
>>From: "Barry Lind" <blind@xythos.com>
>>To: "Paul Sorenson" <pauls@classware.com.au>
>>Sent: Saturday, March 01, 2003 3:57 AM
>>Subject: Re: [JDBC] Can't update rows in tables qualified with schema
>
> names
>
>>
>>>Paul,
>>>
>>>Thanks for the patch.  There are a couple of issues with it that I would
>>>like to mention:
>>>
>>>1) It doesn't correctly handle this case:  schema."Dot.Table"  you
>>>return: Table"
>>>
>>>2) It doesn't completely fix the original bug report.  The proper fix
>>>would be to get both the schema and tablename from the input and pass
>>>both to the getPrimaryKeys() method.  Your patch just ignores the schema
>>>which is incorrect if you happen to have multiple tables with the same
>>>name in different schemas.
>>>
>>>thanks,
>>>--Barry
>>
>>
>>------------------------------------------------------------------------
>>
>>
>>---------------------------(end of broadcast)---------------------------
>>TIP 3: if posting/reading through Usenet, please send an appropriate
>>subscribe-nomail command to majordomo@postgresql.org so that your
>>message can get through to the mailing list cleanly