Обсуждение: RecoveryTargetTLI dead variable in XLogCtlData

Hi all,

I just bumped into $subject, a variable that is never set and never used:
--- a/src/backend/access/transam/xlog.c
+++ b/src/backend/access/transam/xlog.c
@@ -631,8 +631,6 @@ typedef struct XLogCtlData
    TimeLineID  replayEndTLI;
    /* timestamp of last COMMIT/ABORT record replayed (or being replayed) */
    TimestampTz recoveryLastXTime;
-   /* current effective recovery target timeline */
-   TimeLineID  RecoveryTargetTLI;

Thanks,
--
Michael

On Wed, Jul 13, 2016 at 12:29 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> I just bumped into $subject, a variable that is never set and never used:
> --- a/src/backend/access/transam/xlog.c
> +++ b/src/backend/access/transam/xlog.c
> @@ -631,8 +631,6 @@ typedef struct XLogCtlData
>     TimeLineID  replayEndTLI;
>     /* timestamp of last COMMIT/ABORT record replayed (or being replayed) */
>     TimestampTz recoveryLastXTime;
> -   /* current effective recovery target timeline */
> -   TimeLineID  RecoveryTargetTLI;

d57a9734 has missed this cleanup.
-- 
Michael

On Tue, Jul 12, 2016 at 11:29 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> Hi all,
>
> I just bumped into $subject, a variable that is never set and never used:
> --- a/src/backend/access/transam/xlog.c
> +++ b/src/backend/access/transam/xlog.c
> @@ -631,8 +631,6 @@ typedef struct XLogCtlData
>     TimeLineID  replayEndTLI;
>     /* timestamp of last COMMIT/ABORT record replayed (or being replayed) */
>     TimestampTz recoveryLastXTime;
> -   /* current effective recovery target timeline */
> -   TimeLineID  RecoveryTargetTLI;

Committed, thanks.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Jul 22, 2016 at 12:54 AM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Tue, Jul 12, 2016 at 11:29 PM, Michael Paquier
> <michael.paquier@gmail.com> wrote:
>> I just bumped into $subject, a variable that is never set and never used:
>> --- a/src/backend/access/transam/xlog.c
>> +++ b/src/backend/access/transam/xlog.c
>> @@ -631,8 +631,6 @@ typedef struct XLogCtlData
>>     TimeLineID  replayEndTLI;
>>     /* timestamp of last COMMIT/ABORT record replayed (or being replayed) */
>>     TimestampTz recoveryLastXTime;
>> -   /* current effective recovery target timeline */
>> -   TimeLineID  RecoveryTargetTLI;
>
> Committed, thanks.

Thanks.
-- 
Michael