Обсуждение: Memory leak when querying GIN indexes

Hello,

My colleague Adrien reported me a memory leak in GIN indexes while doing
some benchmark on several am.

Here is a test case to reproduce the issue:

CREATE TABLE test AS (
    SELECT t
    FROM generate_series(now(), now() + interval '10 day', '1 second')
AS d(t)
    CROSS JOIN generate_series(1, 100) s
);
CREATE EXTENSON btree_gin;
CREATE INDEX ON test USING gin(t);

EXPLAIN ANALYZE SELECT * FROM test WHERE t >= now() and t < now() +
interval '10 day';

The last query will consume approximately 4GB of RAM (might need to
force index scan) in ExecutorState memory context.

I'm not at all familiar with GIN code, but naive attached patch seems to
fix the issue and not break anything. I can reproduce this issue up to 9.4.

Regards

--
Julien Rouhaud
http://dalibo.com - http://dalibo.org

Julien Rouhaud <julien.rouhaud@dalibo.com> writes:
> My colleague Adrien reported me a memory leak in GIN indexes while doing
> some benchmark on several am.
> ...
> I'm not at all familiar with GIN code, but naive attached patch seems to
> fix the issue and not break anything. I can reproduce this issue up to 9.4.

Yes, this seems right.  Thanks for the report and patch!
        regards, tom lane