Обсуждение: Fix KNN GiST ordering type

Поиск
Список
Период
Сортировка

Fix KNN GiST ordering type

От
Alexander Korotkov
Дата:
Hi!

KNN GiST detects which type it should return by returning type of ordering operator.
But it appears that type of sk_func is detected after it was replaced with distance function. That is wrong: distance function should always return float8.
I think it is just a typo.
Should be backpatched to 9.5.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
Вложения

Re: Fix KNN GiST ordering type

От
Alexander Korotkov
Дата:
On Mon, Feb 1, 2016 at 7:31 PM, Alexander Korotkov <a.korotkov@postgrespro.ru> wrote:
KNN GiST detects which type it should return by returning type of ordering operator.
But it appears that type of sk_func is detected after it was replaced with distance function. That is wrong: distance function should always return float8.
I think it is just a typo.

I found this was introduced by this commit.
http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=821b821a2421beaa58225ff000833df69fb962c5;hp=284bef297733e553c73f1c858e0ce1532f754d18

However, commit message doesn't say anything special about this change.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company