Обсуждение:

Поиск
Список
Период
Сортировка

От
Michael Paquier
Дата:


On Mon, Dec 7, 2015 at 11:37 PM, Fujii Masao <masao.fujii@gmail.com> wrote:
The latest patch has another problem; pg_receivexlog trying to connect to
the PostgreSQL >= 9.4 always reports the following message unexpectedly.

could not identify system: got 1 rows and 4 fields, expected 1 rows
and 4 or more fields

This problem happens because the patch incorrectly treats the case where
IDENTIFY_SYSTEM command returns NULL as database name, as an error case.

Attached is the updated version of the patch, which fixes the problem.
Comments?

The patch looks good. The top comment of RunIdentifySystem is incorrect though. It should mention that a database name is returned and not a plugin name.
--
Michael

Re:

От
Michael Paquier
Дата:
<div dir="ltr"><br /><div class="gmail_extra"><br /><div class="gmail_quote">On Tue, Dec 8, 2015 at 4:37 PM, Michael
Paquier<span dir="ltr"><<a href="mailto:michael.paquier@gmail.com"
target="_blank">michael.paquier@gmail.com</a>></span>wrote:<br /><blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px#ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra">The patch looks good. The top
commentof RunIdentifySystem is incorrect though. It should mention that a database name is returned and not a plugin
name.<spanclass="HOEnZb"><font color="#888888"><br /></font></span></div></div></blockquote></div><br clear="all"
/></div><divclass="gmail_extra">I am not sure what happened here, gmail has suddendly removed the subject of the
email...Sorry for the noise and breaking the thread.<br /></div><div class="gmail_extra">-- <br /><div
class="gmail_signature">Michael<br/></div></div></div>