Обсуждение: Missing latex-longtable value

I have discovered that psql \pset format does not display
"latex-longtable" as a valid value, e.g.:

    test=> \pset format kjasdf
    \pset: allowed formats are unaligned, aligned, wrapped, html, asciidoc, latex, troff-ms

With the attached patch, the latex-longtable value is properly displayed:

    test=> \pset format kjasdf
    \pset: allowed formats are unaligned, aligned, wrapped, html, asciidoc, latex, latex-longtable, troff-ms

Should this be fixed in 9.6 only or 9.5 too?

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + Everyone has their own god. +

Bruce Momjian <bruce@momjian.us> writes:
> I have discovered that psql \pset format does not display
> "latex-longtable" as a valid value, e.g.:

>     test=> \pset format kjasdf
>     \pset: allowed formats are unaligned, aligned, wrapped, html, asciidoc, latex, troff-ms

> With the attached patch, the latex-longtable value is properly displayed:

>     test=> \pset format kjasdf
>     \pset: allowed formats are unaligned, aligned, wrapped, html, asciidoc, latex, latex-longtable, troff-ms

> Should this be fixed in 9.6 only or 9.5 too?

It's a bug.  Back-patch as needed.
        regards, tom lane

On Tue, Jul  7, 2015 at 11:48:13AM -0400, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > I have discovered that psql \pset format does not display
> > "latex-longtable" as a valid value, e.g.:
> 
> >     test=> \pset format kjasdf
> >     \pset: allowed formats are unaligned, aligned, wrapped, html, asciidoc, latex, troff-ms
> 
> > With the attached patch, the latex-longtable value is properly displayed:
> 
> >     test=> \pset format kjasdf
> >     \pset: allowed formats are unaligned, aligned, wrapped, html, asciidoc, latex, latex-longtable, troff-ms
> 
> > Should this be fixed in 9.6 only or 9.5 too?
> 
> It's a bug.  Back-patch as needed.

Doesn't that cause translation string differences that are worse than
the original bug, e.g.:
    psql_error("\\pset: allowed formats are unaligned, aligned, wrapped, html, asciidoc, latex, latex-longtable,
troff-ms\n");

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + Everyone has their own god. +

Bruce Momjian <bruce@momjian.us> writes:
> On Tue, Jul  7, 2015 at 11:48:13AM -0400, Tom Lane wrote:
>> It's a bug.  Back-patch as needed.

> Doesn't that cause translation string differences that are worse than
> the original bug, e.g.:
>      psql_error("\\pset: allowed formats are unaligned, aligned, wrapped, html, asciidoc, latex, latex-longtable,
troff-ms\n");

No.  When we've discussed this sort of thing in the past, people have been
quite clear that they'd rather have accurate messages that come out in
English than inaccurate-though-localized messages.  Certainly we should
avoid gratuitous changes in back-branch localized strings, but this is a
factual error in the message.
        regards, tom lane

On Tue, Jul  7, 2015 at 01:05:09PM -0400, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > On Tue, Jul  7, 2015 at 11:48:13AM -0400, Tom Lane wrote:
> >> It's a bug.  Back-patch as needed.
> 
> > Doesn't that cause translation string differences that are worse than
> > the original bug, e.g.:
> >      psql_error("\\pset: allowed formats are unaligned, aligned, wrapped, html, asciidoc, latex, latex-longtable,
troff-ms\n");
> 
> No.  When we've discussed this sort of thing in the past, people have been
> quite clear that they'd rather have accurate messages that come out in
> English than inaccurate-though-localized messages.  Certainly we should
> avoid gratuitous changes in back-branch localized strings, but this is a
> factual error in the message.

OK, good to know.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + Everyone has their own god. +

On Tue, Jul  7, 2015 at 03:21:50PM -0400, Bruce Momjian wrote:
> On Tue, Jul  7, 2015 at 01:05:09PM -0400, Tom Lane wrote:
> > Bruce Momjian <bruce@momjian.us> writes:
> > > On Tue, Jul  7, 2015 at 11:48:13AM -0400, Tom Lane wrote:
> > >> It's a bug.  Back-patch as needed.
> > 
> > > Doesn't that cause translation string differences that are worse than
> > > the original bug, e.g.:
> > >      psql_error("\\pset: allowed formats are unaligned, aligned, wrapped, html, asciidoc, latex, latex-longtable,
troff-ms\n");
> > 
> > No.  When we've discussed this sort of thing in the past, people have been
> > quite clear that they'd rather have accurate messages that come out in
> > English than inaccurate-though-localized messages.  Certainly we should
> > avoid gratuitous changes in back-branch localized strings, but this is a
> > factual error in the message.
> 
> OK, good to know.

Patch applied back through 9.3, when longtable was added.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + Everyone has their own god. +