Обсуждение: test script, was Re: [COMMITTERS] pgsql: psql: conditionally display oids and replication identity
On Tue, Apr 15, 2014 at 02:46:34PM -0400, Bruce Momjian wrote: > On Tue, Apr 15, 2014 at 02:32:53PM -0400, Tom Lane wrote: > > Bruce Momjian <bruce@momjian.us> writes: > > > psql: conditionally display oids and replication identity > > > > Buildfarm isn't terribly pleased with this --- looks like you missed > > contrib/test_decoding/ > > Fixed. I added a personal script option that allows me to test contrib, > but forgot to run it. Is that script of general utility for committers? If so, it might be good to include it in the distribution. I'd be happy to go through and perl-ify it, document it, etc. Or maybe it could be a new make target... Cheers, David. -- David Fetter <david@fetter.org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david.fetter@gmail.com iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics Remember to vote! Consider donating to Postgres: http://www.postgresql.org/about/donate
On 2014-04-15 12:32:36 -0700, David Fetter wrote: > On Tue, Apr 15, 2014 at 02:46:34PM -0400, Bruce Momjian wrote: > > On Tue, Apr 15, 2014 at 02:32:53PM -0400, Tom Lane wrote: > > > Bruce Momjian <bruce@momjian.us> writes: > > > > psql: conditionally display oids and replication identity > > > > > > Buildfarm isn't terribly pleased with this --- looks like you missed > > > contrib/test_decoding/ > > > > Fixed. I added a personal script option that allows me to test contrib, > > but forgot to run it. > > Is that script of general utility for committers? If so, it might be > good to include it in the distribution. I'd be happy to go through > and perl-ify it, document it, etc. Or maybe it could be a new make > target... "make check-world" Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training & Services
David Fetter <david@fetter.org> writes:
> On Tue, Apr 15, 2014 at 02:46:34PM -0400, Bruce Momjian wrote:
>> Fixed. I added a personal script option that allows me to test contrib,
>> but forgot to run it.
> Is that script of general utility for committers? If so, it might be
> good to include it in the distribution. I'd be happy to go through
> and perl-ify it, document it, etc. Or maybe it could be a new make
> target...
I'm pretty sure "make check-world" would've covered this already.
regards, tom lane
On Tue, Apr 15, 2014 at 12:32:36PM -0700, David Fetter wrote: > On Tue, Apr 15, 2014 at 02:46:34PM -0400, Bruce Momjian wrote: > > On Tue, Apr 15, 2014 at 02:32:53PM -0400, Tom Lane wrote: > > > Bruce Momjian <bruce@momjian.us> writes: > > > > psql: conditionally display oids and replication identity > > > > > > Buildfarm isn't terribly pleased with this --- looks like you missed > > > contrib/test_decoding/ > > > > Fixed. I added a personal script option that allows me to test contrib, > > but forgot to run it. > > Is that script of general utility for committers? If so, it might be > good to include it in the distribution. I'd be happy to go through > and perl-ify it, document it, etc. Or maybe it could be a new make > target... My script is wrapper around src/tools/pgtest. I am attaching it in case there are snippets in there that are useful to people. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + Everyone has their own god. +