Обсуждение: Closing commitfest 2013-11
With apologies to our beloved commitfest-mace-wielding CFM, commitfest 2013-11 intentionally still contains a few open patches. I think that CF is largely being ignored by most people now that we have CF 2014-01 in progress. If we don't want to do anything about these patches in the immediate future, I propose we move them to CF 2014-01. * shared memory message queues This is part of the suite involving dynamic shmem; not sure whether this is a patch that needsmore review, or is it ready for application, or has it been superceded by later versions in the next commitfest. Patchauthors please chime in. * Shave a few instructions from child-process startup sequence Discussion stalled without a conclusion; opinions divergeon whether this is a useful patch to have. My personal inclination is to drop this patch because it seems pointless,but if someone feels otherwise I won't object. (The objection that it will break as soon as we decide to changethe invariant about invalid sockets no longer applies because it has Asserts to that effect.) Do we really care aboutperformance during process termination? I'd say this is mildly interesting if this code is executed for non-authenticatedclients. * Widening application of indices. Was this re-posted in 2014-01? * fault tolerant DROP IF EXISTS I gave a look and it looks good for application. This wasn't superceded by a future version,correct? * SSL: better default ciphersuite I think we should apply this. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> With apologies to our beloved commitfest-mace-wielding CFM, commitfest
> 2013-11 intentionally still contains a few open patches. I think that
> CF is largely being ignored by most people now that we have CF 2014-01
> in progress. If we don't want to do anything about these patches in the
> immediate future, I propose we move them to CF 2014-01.
I think the idea was that patch authors should take responsibility for
pushing their patches forward to 2014-01 if they still wanted them
considered. Quite a few patches already were moved that way, IIRC.
Agreed though that we shouldn't let them just rot.
> * shared memory message queues
Isn't this committed? There's something by that name breaking the
buildfarm ;-)
> * Shave a few instructions from child-process startup sequence
> Discussion stalled without a conclusion; opinions diverge on whether
> this is a useful patch to have. My personal inclination is to drop
> this patch because it seems pointless, but if someone feels otherwise
> I won't object.
I was one of the people objecting to it, so +1 for dropping.
> * Widening application of indices.
> Was this re-posted in 2014-01?
Yes, there's a newer version already in 2014-01.
regards, tom lane
On 20 January 2014 21:24, Alvaro Herrera <alvherre@2ndquadrant.com> wrote: > * fault tolerant DROP IF EXISTS > I gave a look and it looks good for application. This wasn't > superceded by a future version, correct? > No, this hasn't been superceded. +1 for applying it. Regards, Dean
On Mon, Jan 20, 2014 at 4:31 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote: > Alvaro Herrera <alvherre@2ndquadrant.com> writes: >> With apologies to our beloved commitfest-mace-wielding CFM, commitfest >> 2013-11 intentionally still contains a few open patches. I think that >> CF is largely being ignored by most people now that we have CF 2014-01 >> in progress. If we don't want to do anything about these patches in the >> immediate future, I propose we move them to CF 2014-01. > > I think the idea was that patch authors should take responsibility for > pushing their patches forward to 2014-01 if they still wanted them > considered. Quite a few patches already were moved that way, IIRC. Agreed on that general theory. And, also, yeah, the shared memory message queueing stuff got committed. Sorry, I missed the fact that there was still an open CF entry for that; I assumed that it would have been marked Returned with Feedback. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
<p dir="ltr">Hello<p dir="ltr">I disagree with it. There was no any request to move "ready for commit" patches to next commitfest!I expected so only unfinishing patches should by moved there by their authors. I sent question to Peter E. Butwithout reply, but Tom did commits from thist list, so I expected so there is some agreement about it and I did'nt anyalarm.<p dir="ltr">My patch there is prerequsity for "dump --if-exi<div class="gmail_quote">Dne 21.1.2014 17:41 "RobertHaas" <<a href="mailto:robertmhaas@gmail.com">robertmhaas@gmail.com</a>> napsal(a):<br type="attribution" /><blockquoteclass="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> On Mon, Jan 20, 2014at 4:31 PM, Tom Lane <<a href="mailto:tgl@sss.pgh.pa.us">tgl@sss.pgh.pa.us</a>> wrote:<br /> > Alvaro Herrera<<a href="mailto:alvherre@2ndquadrant.com">alvherre@2ndquadrant.com</a>> writes:<br /> >> With apologiesto our beloved commitfest-mace-wielding CFM, commitfest<br /> >> 2013-11 intentionally still contains a fewopen patches. I think that<br /> >> CF is largely being ignored by most people now that we have CF 2014-01<br />>> in progress. If we don't want to do anything about these patches in the<br /> >> immediate future, I proposewe move them to CF 2014-01.<br /> ><br /> > I think the idea was that patch authors should take responsibilityfor<br /> > pushing their patches forward to 2014-01 if they still wanted them<br /> > considered. Quitea few patches already were moved that way, IIRC.<br /><br /> Agreed on that general theory.<br /><br /> And, also,yeah, the shared memory message queueing stuff got<br /> committed. Sorry, I missed the fact that there was still anopen CF<br /> entry for that; I assumed that it would have been marked Returned with<br /> Feedback.<br /><br /> --<br/> Robert Haas<br /> EnterpriseDB: <a href="http://www.enterprisedb.com" target="_blank">http://www.enterprisedb.com</a><br/> The Enterprise PostgreSQL Company<br /><br /><br /> --<br /> Sent viapgsql-hackers mailing list (<a href="mailto:pgsql-hackers@postgresql.org">pgsql-hackers@postgresql.org</a>)<br /> To makechanges to your subscription:<br /><a href="http://www.postgresql.org/mailpref/pgsql-hackers" target="_blank">http://www.postgresql.org/mailpref/pgsql-hackers</a><br/></blockquote></div>
<p dir="ltr"><br /> Dne 21.1.2014 18:52 "Pavel Stehule" <<a href="mailto:pavel.stehule@gmail.com">pavel.stehule@gmail.com</a>>napsal(a):<br /> ><br /> > Hello<br /> ><br/> > I disagree with it. There was no any request to move "ready for commit" patches to next commitfest! I expectedso only unfinishing patches should by moved there by their authors. I sent question to Peter E. But without reply,but Tom did commits from thist list, so I expected so there is some agreement about it and I did'nt any alarm.<br />><br /> > My patch there is prerequsity for "dump --if-exi<p dir="ltr">Sorry, train and mobile :(<p dir="ltr">Itis required for "dump --if-exists" feature.<p dir="ltr">Regards<p dir="ltr">Pavel<br /> ><br /> > Dne 21.1.201417:41 "Robert Haas" <<a href="mailto:robertmhaas@gmail.com">robertmhaas@gmail.com</a>> napsal(a):<br /> ><br/> >> On Mon, Jan 20, 2014 at 4:31 PM, Tom Lane <<a href="mailto:tgl@sss.pgh.pa.us">tgl@sss.pgh.pa.us</a>>wrote:<br /> >> > Alvaro Herrera <<a href="mailto:alvherre@2ndquadrant.com">alvherre@2ndquadrant.com</a>>writes:<br /> >> >> With apologies toour beloved commitfest-mace-wielding CFM, commitfest<br /> >> >> 2013-11 intentionally still contains a fewopen patches. I think that<br /> >> >> CF is largely being ignored by most people now that we have CF 2014-01<br/> >> >> in progress. If we don't want to do anything about these patches in the<br /> >> >>immediate future, I propose we move them to CF 2014-01.<br /> >> ><br /> >> > I think the ideawas that patch authors should take responsibility for<br /> >> > pushing their patches forward to 2014-01 ifthey still wanted them<br /> >> > considered. Quite a few patches already were moved that way, IIRC.<br /> >><br/> >> Agreed on that general theory.<br /> >><br /> >> And, also, yeah, the shared memory messagequeueing stuff got<br /> >> committed. Sorry, I missed the fact that there was still an open CF<br /> >>entry for that; I assumed that it would have been marked Returned with<br /> >> Feedback.<br /> >><br/> >> --<br /> >> Robert Haas<br /> >> EnterpriseDB: <a href="http://www.enterprisedb.com">http://www.enterprisedb.com</a><br/> >> The Enterprise PostgreSQL Company<br />>><br /> >><br /> >> --<br /> >> Sent via pgsql-hackers mailing list (<a href="mailto:pgsql-hackers@postgresql.org">pgsql-hackers@postgresql.org</a>)<br/> >> To make changes to your subscription:<br/> >> <a href="http://www.postgresql.org/mailpref/pgsql-hackers">http://www.postgresql.org/mailpref/pgsql-hackers</a><br/>
On 01/20/2014 10:31 PM, Tom Lane wrote: > I think the idea was that patch authors should take responsibility for > pushing their patches forward to 2014-01 if they still wanted them > considered. Quite a few patches already were moved that way, IIRC. > > Agreed though that we shouldn't let them just rot. Does this mean I can resurrect my pg_sleep_until() patch? I didn't set it back to Needs Review after I completely changed my approach based on feedback. I would hate for it to get lost just because I didn't know how to use the commitfest app. https://commitfest.postgresql.org/action/patch_view?id=1189 -- Vik
Vik Fearing wrote: > On 01/20/2014 10:31 PM, Tom Lane wrote: > > I think the idea was that patch authors should take responsibility for > > pushing their patches forward to 2014-01 if they still wanted them > > considered. Quite a few patches already were moved that way, IIRC. > > > > Agreed though that we shouldn't let them just rot. > > Does this mean I can resurrect my pg_sleep_until() patch? I didn't set > it back to Needs Review after I completely changed my approach based on > feedback. I would hate for it to get lost just because I didn't know > how to use the commitfest app. > > https://commitfest.postgresql.org/action/patch_view?id=1189 No objection here. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
Alvaro Herrera wrote: > With apologies to our beloved commitfest-mace-wielding CFM, commitfest > 2013-11 intentionally still contains a few open patches. I think that > CF is largely being ignored by most people now that we have CF 2014-01 > in progress. If we don't want to do anything about these patches in the > immediate future, I propose we move them to CF 2014-01. > > * shared memory message queues I closed this one as committed. > * Shave a few instructions from child-process startup sequence > * Widening application of indices. I marked these as returned with feedback. > * fault tolerant DROP IF EXISTS Committed this one and marked as such. > * SSL: better default ciphersuite This one was moved to 2014-01 (not by me). So there is nothing remaining in 2013-11 and we can (continue to) focus exclusively on 2014-01. Yay! -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services