Обсуждение: [PATCH] Doc fix for VACUUM FREEZE

Поиск
Список
Период
Сортировка

[PATCH] Doc fix for VACUUM FREEZE

От
Maciek Sakrejda
Дата:
<div dir="ltr">VACUUM FREEZE sets both vacuum_freeze_min_age and vacuum_freeze_table_age to 0, but only the former is
documented.This patch notes that the other setting is also affected.<br /></div> 

Re: [PATCH] Doc fix for VACUUM FREEZE

От
Maciek Sakrejda
Дата:
(now with patch--sorry about that)
Вложения

Re: [PATCH] Doc fix for VACUUM FREEZE

От
Amit Kapila
Дата:
On Wed, Dec 18, 2013 at 6:46 AM, Maciek Sakrejda <m.sakrejda@gmail.com> wrote:
>VACUUM FREEZE sets both vacuum_freeze_min_age and vacuum_freeze_table_age to 0, but only the former is documented.
Thispatch notes that the other setting is also affected.
 
> (now with patch--sorry about that)

Your explanation and patch seems fine to me.
Kindly submit your patch in Open CommitFest
(https://commitfest.postgresql.org/action/commitfest_view?id=21).

With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com



Re: [PATCH] Doc fix for VACUUM FREEZE

От
Peter Eisentraut
Дата:
On 12/17/13, 8:16 PM, Maciek Sakrejda wrote:
> (now with patch--sorry about that)

This patch doesn't apply.




Re: [PATCH] Doc fix for VACUUM FREEZE

От
Amit Kapila
Дата:
On Fri, Jan 3, 2014 at 9:02 PM, Peter Eisentraut <peter_e@gmx.net> wrote:
> On 12/17/13, 8:16 PM, Maciek Sakrejda wrote:
>> (now with patch--sorry about that)
>
> This patch doesn't apply.

There are some recent changes around same place which broke this
patch. Please find the modified patch attached with this mail, I had
changed order of specifying vacuum_freeze_min_age and
vacuum_freeze_table_age in Vacuum FREEZE option.

I will mark this patch as Ready For Committer, unless there is
any other objection for this patch.


With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

Вложения

Re: [PATCH] Doc fix for VACUUM FREEZE

От
Robert Haas
Дата:
On Tue, Jan 14, 2014 at 2:39 AM, Amit Kapila <amit.kapila16@gmail.com> wrote:
> On Fri, Jan 3, 2014 at 9:02 PM, Peter Eisentraut <peter_e@gmx.net> wrote:
>> On 12/17/13, 8:16 PM, Maciek Sakrejda wrote:
>>> (now with patch--sorry about that)
>>
>> This patch doesn't apply.
>
> There are some recent changes around same place which broke this
> patch. Please find the modified patch attached with this mail, I had
> changed order of specifying vacuum_freeze_min_age and
> vacuum_freeze_table_age in Vacuum FREEZE option.
>
> I will mark this patch as Ready For Committer, unless there is
> any other objection for this patch.

Committed with a grammatical correction.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company