Обсуждение: Minor fix in 'clean' action of 'src/backend/Makefile'
Hi all,
The attached patch fix it.
--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
>> Blog sobre TI: http://fabriziomello.blogspot.com
>> Perfil Linkedin: http://br.linkedin.com/in/fabriziomello
>> Twitter: http://twitter.com/fabriziomello
Regards,
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
>> Blog sobre TI: http://fabriziomello.blogspot.com
>> Perfil Linkedin: http://br.linkedin.com/in/fabriziomello
>> Twitter: http://twitter.com/fabriziomello
Вложения
On 02.01.2013 18:05, Fabrízio de Royes Mello wrote: > Hi all, > > When we execute 'make clean' the file 'src/backend/replication/repl_gram.h' > is not removed. That's on purpose. repl_gram.h is generated by bison, along with repl_gram.c. Neither is removed by "make clean", because they're needed in a distribution tarball. "make maintainer-clean" does remove them. Hmm, looking closer though, repl_gram.h is not actually needed for anything, though. We could just remove the -d flag from the bison invocation and not build it to begin with. I'll go and do that.. - Heikki
On 02.01.2013 18:20, Heikki Linnakangas wrote: > Hmm, looking closer though, repl_gram.h is not actually needed for > anything, though. We could just remove the -d flag from the bison > invocation and not build it to begin with. I'll go and do that.. And looking even closer, we don't use the -d flag in git master anymore, so repl_gram.h is not being built, and there's nothing to do here. I suppose we could change back-branches to also not build it, but I don't think I'm going to bother. - Heikki
<div dir="ltr"><br /><div class="gmail_extra"><div class="gmail_quote">On Wed, Jan 2, 2013 at 2:23 PM, Heikki Linnakangas<span dir="ltr"><<a href="mailto:hlinnakangas@vmware.com" target="_blank">hlinnakangas@vmware.com</a>></span>wrote:<br /><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px#ccc solid;padding-left:1ex"><div class="im">On 02.01.2013 18:20, Heikki Linnakangas wrote:<br /><blockquoteclass="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Hmm, looking closerthough, repl_gram.h is not actually needed for<br /> anything, though. We could just remove the -d flag from the bison<br/> invocation and not build it to begin with. I'll go and do that..<br /></blockquote><br /></div> And looking evencloser, we don't use the -d flag in git master anymore, so repl_gram.h is not being built, and there's nothing to dohere. I suppose we could change back-branches to also not build it, but I don't think I'm going to bother.<span class="HOEnZb"><fontcolor="#888888"><br /><br /></font></span></blockquote></div><div class="gmail_extra"><br /></div>Youall right... thanks....</div><div class="gmail_extra"><br />-- <br />Fabrízio de Royes Mello<br />Consultoria/CoachingPostgreSQL<br />>> Blog sobre TI: <a href="http://fabriziomello.blogspot.com" target="_blank">http://fabriziomello.blogspot.com</a><br/> >> Perfil Linkedin: <a href="http://br.linkedin.com/in/fabriziomello"target="_blank">http://br.linkedin.com/in/fabriziomello</a><br />>> Twitter:<a href="http://twitter.com/fabriziomello" target="_blank">http://twitter.com/fabriziomello</a><br /></div></div>