Обсуждение: Re: [COMMITTERS] pgsql: Add mode where contrib installcheck runs each module in a separa

Поиск
Список
Период
Сортировка

Re: [COMMITTERS] pgsql: Add mode where contrib installcheck runs each module in a separa

От
Tom Lane
Дата:
Andrew Dunstan <andrew@dunslane.net> writes:
> On 12/03/2012 01:45 PM, Alvaro Herrera wrote:
>> $ LC_ALL=C make
>> Makefile:15: invalid `override' directive

> Well, you seem to have more problems than just the database name.

I see this too.  Given that I want to wrap the back branches in a few
minutes, please revert at least in the back branches.  I can't wait
for you to sort this out.

            regards, tom lane


Re: [COMMITTERS] pgsql: Add mode where contrib installcheck runs each module in a separa

От
Andrew Dunstan
Дата:
On 12/03/2012 02:46 PM, Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
>> On 12/03/2012 01:45 PM, Alvaro Herrera wrote:
>>> $ LC_ALL=C make
>>> Makefile:15: invalid `override' directive
>> Well, you seem to have more problems than just the database name.
> I see this too.  Given that I want to wrap the back branches in a few
> minutes, please revert at least in the back branches.  I can't wait
> for you to sort this out.
>
>


OK. I reverted the lot.

will do.

cheers

andrew



Re: [COMMITTERS] pgsql: Add mode where contrib installcheck runs each module in a separa

От
Andrew Dunstan
Дата:
On 12/03/2012 04:02 PM, Andrew Dunstan wrote:
>
>
>
> Looks like undefine is a new feature in gmake 3.82. I can reproduce
> this on my SL6 box which has 3.81. I'll have to come up with something
> other than ifdef, like
>
>     ifneq ($(USE_MODULE_DB),)
>
> and use the override in dblink's Makefile to set it to the empty string.
>
>
>


Here's a version that seems to work with pre 3.82 versions of gmake.

cheers

andrew


Вложения