Обсуждение: Re: [COMMITTERS] pgsql: Remove useless whitespace at end of lines
Alvaro Herrera <alvherre@commandprompt.com> writes:
> Excerpts from Peter Eisentraut's message of mar nov 23 17:52:18 -0300 2010:
>> Remove useless whitespace at end of lines
> This was stuck in the moderation queue because of message size limit (30
> kB). Is it worth increasing that value?
Evidently we should. pgindent and copyright-update commits are likely
to be at least this long.
regards, tom lane
On Wed, Nov 24, 2010 at 23:45, Tom Lane <tgl@sss.pgh.pa.us> wrote: > Alvaro Herrera <alvherre@commandprompt.com> writes: >> Excerpts from Peter Eisentraut's message of mar nov 23 17:52:18 -0300 2010: >>> Remove useless whitespace at end of lines > >> This was stuck in the moderation queue because of message size limit (30 >> kB). Is it worth increasing that value? > > Evidently we should. pgindent and copyright-update commits are likely > to be at least this long. That's twice a year only - I don't see a big problem moderating those when it happens... -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/
Magnus Hagander wrote: > On Wed, Nov 24, 2010 at 23:45, Tom Lane <tgl@sss.pgh.pa.us> wrote: > > Alvaro Herrera <alvherre@commandprompt.com> writes: > >> Excerpts from Peter Eisentraut's message of mar nov 23 17:52:18 -0300 2010: > >>> Remove useless whitespace at end of lines > > > >> This was stuck in the moderation queue because of message size limit (30 > >> kB). ?Is it worth increasing that value? > > > > Evidently we should. ?pgindent and copyright-update commits are likely > > to be at least this long. > > That's twice a year only - I don't see a big problem moderating those > when it happens... I do love to see my big pgindent commits come through. You can hear the wind rustling though the code. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + It's impossible for everything to be true. +
Magnus Hagander <magnus@hagander.net> writes:
> On Wed, Nov 24, 2010 at 23:45, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Alvaro Herrera <alvherre@commandprompt.com> writes:
>>> This was stuck in the moderation queue because of message size limit (30
>>> kB). �Is it worth increasing that value?
>>
>> Evidently we should. �pgindent and copyright-update commits are likely
>> to be at least this long.
> That's twice a year only - I don't see a big problem moderating those
> when it happens...
Its not so much the moderation load, as I don't like being blindsided by
commits that touch everything in sight. Finding out only when you try
to do git push (as indeed happened to me just this afternoon because of
this patch) is annoying.
regards, tom lane
On Wed, Nov 24, 2010 at 23:54, Tom Lane <tgl@sss.pgh.pa.us> wrote: > Magnus Hagander <magnus@hagander.net> writes: >> On Wed, Nov 24, 2010 at 23:45, Tom Lane <tgl@sss.pgh.pa.us> wrote: >>> Alvaro Herrera <alvherre@commandprompt.com> writes: >>>> This was stuck in the moderation queue because of message size limit (30 >>>> kB). Is it worth increasing that value? >>> >>> Evidently we should. pgindent and copyright-update commits are likely >>> to be at least this long. > >> That's twice a year only - I don't see a big problem moderating those >> when it happens... > > Its not so much the moderation load, as I don't like being blindsided by > commits that touch everything in sight. Finding out only when you try > to do git push (as indeed happened to me just this afternoon because of > this patch) is annoying. fair enough. I'm not sure the size limit actually protects us against anything, so I'm not against increasing it. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/
Excerpts from Magnus Hagander's message of jue nov 25 05:46:49 -0300 2010: > On Wed, Nov 24, 2010 at 23:54, Tom Lane <tgl@sss.pgh.pa.us> wrote: > > Its not so much the moderation load, as I don't like being blindsided by > > commits that touch everything in sight. Finding out only when you try > > to do git push (as indeed happened to me just this afternoon because of > > this patch) is annoying. > > fair enough. I'm not sure the size limit actually protects us against > anything, so I'm not against increasing it. So, given that this commit touched 517 files and resulted in a 47341b message, the minimum size we should use is about 332kB for the 3633 files present in the source tree (I counted all the files, not just the ones with copyright lines, out of pure laziness). I've set the limit to 400 kB to have a wide safety margin. Large commits should now pass through unmoderated. -- Álvaro Herrera <alvherre@commandprompt.com> The PostgreSQL Company - Command Prompt, Inc. PostgreSQL Replication, Consulting, Custom Development, 24x7 support