Обсуждение: Re: [COMMITTERS] pgsql: git_topo_order script, to match up commits across branches.
Re: [COMMITTERS] pgsql: git_topo_order script, to match up commits across branches.
От
Gurjeet Singh
Дата:
On Fri, Sep 24, 2010 at 6:09 PM, Alvaro Herrera <alvherre@commandprompt.com> wrote:
If it resembles cvs2cl then why not name it git2cl? Or git_changelog.
Since it doesn't do anything specific to Postgres' git, lets not have any pg in there.
Regards,
-- Excerpts from Tom Lane's message of vie sep 24 17:36:59 -0400 2010:> Robert Haas <robertmhaas@gmail.com> writes:How about something content-free like "pg_git_log"?
> > On Sep 24, 2010, at 3:32 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> >> BTW ... I don't especially care for the name you picked for this script.
> >> The fact that it does a topological sort is an implementation detail
> >> that its users couldn't care less about, especially since that doesn't
> >> matter except for corner cases. How about "collate_git_log" or
> >> something along it.
>
> > I don't think that's any better - collate could mean anything - but I don't think it's any worse, either. Change it if you want.
>
> Well, I definitely think that the name should suggest a connection to
> "git log". I agree that "collate" might not be the best possible verb
> here --- anyone have a better suggestion?
If it resembles cvs2cl then why not name it git2cl? Or git_changelog.
Since it doesn't do anything specific to Postgres' git, lets not have any pg in there.
Regards,
gurjeet.singh
@ EnterpriseDB - The Enterprise Postgres Company
http://www.EnterpriseDB.com
singh.gurjeet@{ gmail | yahoo }.com
Twitter/Skype: singh_gurjeet
Mail sent from my BlackLaptop device
Re: Re: [COMMITTERS] pgsql: git_topo_order script, to match up commits across branches.
От
Andrew Dunstan
Дата:
On 09/24/2010 06:53 PM, Gurjeet Singh wrote: > If it resembles cvs2cl then why not name it git2cl? Or git_changelog. > > +1 for git_changelog cheers andrew
Re: [COMMITTERS] pgsql: git_topo_order script, to match up commits across branches.
От
Robert Haas
Дата:
On Fri, Sep 24, 2010 at 6:53 PM, Gurjeet Singh <singh.gurjeet@gmail.com> wrote: > Since it doesn't do anything specific to Postgres' git, lets not have any pg > in there. Assuming you discount the hard-coded list of our active branch heads, of course. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgres Company
Re: [COMMITTERS] pgsql: git_topo_order script, to match up commits across branches.
От
Alvaro Herrera
Дата:
Excerpts from Robert Haas's message of vie sep 24 22:20:54 -0400 2010: > On Fri, Sep 24, 2010 at 6:53 PM, Gurjeet Singh <singh.gurjeet@gmail.com> wrote: > > Since it doesn't do anything specific to Postgres' git, lets not have any pg > > in there. > > Assuming you discount the hard-coded list of our active branch heads, of course. Also, I thought it resembled pgcvslog more than cvs2cl. +1 to git_changelog anyway. -- Álvaro Herrera <alvherre@commandprompt.com> The PostgreSQL Company - Command Prompt, Inc. PostgreSQL Replication, Consulting, Custom Development, 24x7 support