Обсуждение: compile error with -DOPTIMIZER_DEBUG

Hi,

ISTM that there's a superfluous curly brace in print_path (which only
gets compiled with -DOPTIMIZER_DEBUG.

Patch attached.

Jan
diff --git a/src/backend/optimizer/path/allpaths.c b/src/backend/optimizer/path/allpaths.c
index bfadcb0..6b2f86c 100644
--- a/src/backend/optimizer/path/allpaths.c
+++ b/src/backend/optimizer/path/allpaths.c
@@ -1449,7 +1449,6 @@ print_path(PlannerInfo *root, Path *path, int indent)
                    ((mp->outersortkeys) ? 1 : 0),
                    ((mp->innersortkeys) ? 1 : 0),
                    ((mp->materialize_inner) ? 1 : 0));
-            }
         }

         print_path(root, jp->outerjoinpath, indent + 1);

Jan Urbański wrote:
> ISTM that there's a superfluous curly brace in print_path (which only
> gets compiled with -DOPTIMIZER_DEBUG.
> 
> Patch attached.

Thanks, committed.

--  Heikki Linnakangas EnterpriseDB   http://www.enterprisedb.com

Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> writes:
> Jan Urbański wrote:
>> ISTM that there's a superfluous curly brace in print_path (which only
>> gets compiled with -DOPTIMIZER_DEBUG.

> Thanks, committed.

You know, the last couple of times I've touched that code, I've been
wondering why we bother to maintain it.  Personally I always use pprint()
when I'm interested in a printout of a plan tree.  Is anyone actually
using the printout code in allpaths.c?
        regards, tom lane

Tom Lane wrote:
> Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> writes:
> > Jan Urbański wrote:
> >> ISTM that there's a superfluous curly brace in print_path (which only
> >> gets compiled with -DOPTIMIZER_DEBUG.
> 
> > Thanks, committed.
> 
> You know, the last couple of times I've touched that code, I've been
> wondering why we bother to maintain it.  Personally I always use pprint()
> when I'm interested in a printout of a plan tree.  Is anyone actually
> using the printout code in allpaths.c?

I thought OPTIMIZER_DEBUG showed us all the possible paths, not just the
final plan.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +

Bruce Momjian <bruce@momjian.us> writes:
> Tom Lane wrote:
>> You know, the last couple of times I've touched that code, I've been
>> wondering why we bother to maintain it.  Personally I always use pprint()
>> when I'm interested in a printout of a plan tree.  Is anyone actually
>> using the printout code in allpaths.c?

> I thought OPTIMIZER_DEBUG showed us all the possible paths, not just the
> final plan.

Yeah, but we could repoint that code at pprint.
        regards, tom lane

Tom Lane wrote:
> Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> writes:
> > Jan Urbański wrote:
> >> ISTM that there's a superfluous curly brace in print_path (which only
> >> gets compiled with -DOPTIMIZER_DEBUG.
> 
> > Thanks, committed.
> 
> You know, the last couple of times I've touched that code, I've been
> wondering why we bother to maintain it.  Personally I always use pprint()
> when I'm interested in a printout of a plan tree.  Is anyone actually
> using the printout code in allpaths.c?

Maybe Tom Raney's Visual Planner thing?

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support