Обсуждение: CommitFest 2009-11 Call for Reviewers
In a few days the 3rd 8.5 development CommitFest, 2009-11, is going to kick off, with the end goal being an alpha3 prerelease. If you have a patch in progress, you'll need to submit it before the deadline of 2009-11-15 00:00:00 GMT for it to be considered during this round: http://wiki.postgresql.org/wiki/Submitting_a_Patch The actual process of the CommitFest itself is fairly well documented at this point: http://wiki.postgresql.org/wiki/Reviewing_a_Patch http://wiki.postgresql.org/wiki/RRReviewers http://wiki.postgresql.org/wiki/Running_a_CommitFest For lack of a more qualified volunteer, I'll be handling the initial round of patch assignments and reviewer organization. I suspect we'll reorganize on the fly as things proceed based on who has time; I'd certainly welcome patch-chasing help in addition to reviewing. Since the backlog for this CommitFest is so far lighter than we've seen recently, the small patches that don't already have an active reviewer shouldn't be too difficult to get through. Please send me an email (without copying the list) if you are available to help with review. Include any information that might be helpful in assigning you an appropriate patch. If there's a specific one you want to claim, by all means let me know that. All reviewers will need to be subscribed to the RRR mailing list, so when you write me please also follow the subscription link at http://archives.postgresql.org/pgsql-rrreviewers/ to add yourself to that list, too, if you're not already there. The set of patches I have the least feel for are the five ECPG submissions, some of which were reviewed already. I would particularly appreciate any early information reviewers might provide about their capability/willingness to work on that set. Those are not so easy to just split among multiple people due to how they relate to one another. -- Greg Smith 2ndQuadrant Baltimore, MD PostgreSQL Training, Services and Support greg@2ndQuadrant.com www.2ndQuadrant.com
On 11/12/09 9:45 AM, Greg Smith wrote: > For lack of a more qualified volunteer, I'll be handling the initial > round of patch assignments and reviewer organization. Hmmm? Who's more qualified than you, exactly? --Josh Berkus
Josh Berkus wrote:
I was alluding to the fact that Robert isn't available to handle this one.On 11/12/09 9:45 AM, Greg Smith wrote:For lack of a more qualified volunteer, I'll be handling the initial round of patch assignments and reviewer organization.Hmmm? Who's more qualified than you, exactly?
-- Greg Smith 2ndQuadrant Baltimore, MD PostgreSQL Training, Services and Support greg@2ndQuadrant.com www.2ndQuadrant.com
Greg Smith <greg@2ndquadrant.com> writes:
> The set of patches I have the least feel for are the five ECPG
> submissions, some of which were reviewed already. I would particularly
> appreciate any early information reviewers might provide about their
> capability/willingness to work on that set. Those are not so easy to
> just split among multiple people due to how they relate to one another.
AFAIK the ecpg patches are all waiting on Michael Meskes to have time
to review/commit them. ecpg is pretty much his turf and no other
committers are likely to touch these patches. If anyone really wants
to review them, of course, that's fine ... but I don't think you should
assign them to someone just because the CF process says to.
regards, tom lane
Tom Lane wrote: > Greg Smith <greg@2ndquadrant.com> writes: > > The set of patches I have the least feel for are the five ECPG > > submissions, some of which were reviewed already. I would particularly > > appreciate any early information reviewers might provide about their > > capability/willingness to work on that set. Those are not so easy to > > just split among multiple people due to how they relate to one another. > > AFAIK the ecpg patches are all waiting on Michael Meskes to have time > to review/commit them. ecpg is pretty much his turf and no other > committers are likely to touch these patches. If anyone really wants > to review them, of course, that's fine ... but I don't think you should > assign them to someone just because the CF process says to. FWIW I committed the parts of one of these patches that touched the core grammar mostly, because I think those might have been holding Michael back a bit. Hopefully that'll make it easier for him to review the rest. -- Alvaro Herrera http://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc.
Tom Lane wrote: > AFAIK the ecpg patches are all waiting on Michael Meskes to have time > to review/commit them. ecpg is pretty much his turf and no other > committers are likely to touch these patches. Great to know, and since some of the regular reviewers already made a pass through them there's probably not too much general feedback left anyway. I just marked all of those as having Michael as the reviewer. If it gets to where those are the main remaining hold-up I guess we'll revisit who else might help out then. Would rather get the patches it's more obvious how to handle out of the way first. Not considering those, HS/SR, or other patches with an already assigned reviewer, we're at 16 patches in the queue, and I've got 9 reviewer volunteers just so far today. Barring a flood of last-minute entries, if I can get each reviewer to handle one patch and a moderate percentage of them to handle two, that should be all it takes for this round. Will move the rest of the discussion here to just rrreviewers. -- Greg Smith 2ndQuadrant Baltimore, MD PostgreSQL Training, Services and Support greg@2ndQuadrant.com www.2ndQuadrant.com
On Thu, Nov 12, 2009 at 04:52:20PM -0300, Alvaro Herrera wrote: > FWIW I committed the parts of one of these patches that touched the core Thanks for your help. > grammar mostly, because I think those might have been holding Michael > back a bit. Hopefully that'll make it easier for him to review the No, not really. I don't mind reviewing and committing to the core grammar at all. What holds me back is simply my lack of time. michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org ICQ: 179140304, AIM/Yahoo/Skype: michaelmeskes, Jabber: meskes@jabber.org VfL Borussia! Forca Barca! Go SF 49ers! Use: Debian GNU/Linux, PostgreSQL