Обсуждение: VARSIZE - why omit VARLEN?

Поиск
Список
Период
Сортировка

VARSIZE - why omit VARLEN?

От
Andrew Chernow
Дата:
Any objections adding the below to postgres.h?

#define VARLEN(PTR) (VARSIZE(PTR) - VARHDRSZ)

It adds a little more abstraction and cleans up userland code.

-- 
Andrew Chernow
eSilo, LLC
every bit counts
http://www.esilo.com/


Re: VARSIZE - why omit VARLEN?

От
Tom Lane
Дата:
Andrew Chernow <ac@esilo.com> writes:
> Any objections adding the below to postgres.h?
> #define VARLEN(PTR) (VARSIZE(PTR) - VARHDRSZ)

For the most part, you should probably be using VARSIZE_ANY_EXHDR
anyplace that that might be a good idea.
        regards, tom lane


Re: VARSIZE - why omit VARLEN?

От
Andrew Chernow
Дата:
Tom Lane wrote:
> Andrew Chernow <ac@esilo.com> writes:
>> Any objections adding the below to postgres.h?
>> #define VARLEN(PTR) (VARSIZE(PTR) - VARHDRSZ)
> 
> For the most part, you should probably be using VARSIZE_ANY_EXHDR
> anyplace that that might be a good idea.
> 
>             regards, tom lane
> 
> 

Thanks, that will do it.  I didn't know that macro existed.  I missed its 
addition in 8.3.  sorry.

-- 
Andrew Chernow
eSilo, LLC
every bit counts
http://www.esilo.com/