Обсуждение: My review for the patch "Table command"

Поиск
Список
Период
Сортировка

My review for the patch "Table command"

От
Unicron
Дата:
<table border="0" cellpadding="0" cellspacing="0"><tr><td style="font: inherit;" valign="top">Hi<br />   I have
completedthe review for Patch "Table command", Here is results<br />   1. The patch actually implements that.<br />  
2.The feature work as advertised.<br />   3. So far, I have not found any possible dangers that can be caused by this
pacth<br/>   4. Since it is just an alternative to "select * from Table",  I think this feature is <br />      
unneccessary.<br/><br />                                                                  Unicron <br
/></td></tr></table><br/> 

Re: My review for the patch "Table command"

От
Josh Berkus
Дата:
Unicron,

>    4. Since it is just an alternative to "select * from Table",  I think 
> this feature is
>        unneccessary.

Heh.  I agree, but tell that to the SQL committee.

I don't think we need to argue out the merits of adding standard syntax.

This patch is Ready for Code Review.

--Josh


Re: My review for the patch "Table command"

От
Tom Lane
Дата:
Josh Berkus <josh@agliodbs.com> writes:
> Unicron,
>> 4. Since it is just an alternative to "select * from Table",  I think 
>> this feature is unneccessary.

> Heh.  I agree, but tell that to the SQL committee.

> I don't think we need to argue out the merits of adding standard syntax.

We can, however, argue the merits of making extensive documentation
changes to document such a useless "feature".
        regards, tom lane