Обсуждение: Signal handling patch (v2) for Synch Rep

Hi,

To be reviewed easily, I'm splitting Synch Rep patch into some pieces.
Attached is a patch of signal handling changes for Synch Rep.

http://archives.postgresql.org/pgsql-hackers/2008-09/msg00950.php

Though I've posted the WIP patch previously, this is a finished one.
Please feel free to comment on it.

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

On Tue, 2008-11-04 at 21:04 +0900, Fujii Masao wrote:

> To be reviewed easily, I'm splitting Synch Rep patch into some pieces.

Great idea. I'll be doing that also.

-- Simon Riggs           www.2ndQuadrant.comPostgreSQL Training, Services and Support

Fujii Masao wrote:
> Attached is a patch of signal handling changes for Synch Rep.

It seems that we wouldn't need to use the BackendPidGetProc function, 
nor the new AuxiliaryPidGetProc function, if we stored a PGPROC * 
instead of the pid in ProcState.procPid.

--   Heikki Linnakangas  EnterpriseDB   http://www.enterprisedb.com

On Sat, Nov 15, 2008 at 6:12 AM, Heikki Linnakangas
<heikki.linnakangas@enterprisedb.com> wrote:
> Fujii Masao wrote:
>>
>> Attached is a patch of signal handling changes for Synch Rep.
>
> It seems that we wouldn't need to use the BackendPidGetProc function, nor
> the new AuxiliaryPidGetProc function, if we stored a PGPROC * instead of the
> pid in ProcState.procPid.

Sounds good! That can cut back on ProcArrayLock.

And, I add the code which deletes the request from WalSenderShmem
when the backend dies or aborts. I would call the delete function within
AbortTransaction(), and add it as a callback function (on_shmem_exit).

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center