Обсуждение: 8.3 version of ts_headline

Hi.
In 8.2 this produces an error:

SELECT headline('default', 'a b c', 'c'::tsquery,
'StartSel=<span class="style1">, StopSel=</span>');
ERROR:  syntax error
DETAIL:  Syntax error in position 15.

while this works:
SELECT headline('default', 'a b c', 'c'::tsquery,
'StartSel=<b>, StopSel=</b>');  headline
--------------a b <b>c</b>
(1 row)

In the modern age people use stylesheets and it seems awkward that it's not
possible to highlight headlines using stylesheets in PG. Is this intentional,
or a glitch? Is it possible to extend ts_headline to support more advanced
markup in StartSel?

--
Andreas Joseph Krogh <andreak@officenet.no>
Senior Software Developer / Manager
------------------------+---------------------------------------------+
OfficeNet AS            | The most difficult thing in the world is to |
Karenslyst Allé 11      | know how to do a thing and to watch         |
PO. Box 529 Skøyen      | somebody else doing it wrong, without       |
0214 Oslo               | comment.                                    |
NORWAY                  |                                             |
Tlf:    +47 24 15 38 90 |                                             |
Fax:    +47 24 15 38 91 |                                             |
Mobile: +47 909  56 963 |                                             |
------------------------+---------------------------------------------+

Andreas Joseph Krogh <andreak@officenet.no> writes:
> In 8.2 this produces an error:

> SELECT headline('default', 'a b c', 'c'::tsquery,
> 'StartSel=<span class="style1">, StopSel=</span>');
> ERROR:  syntax error
> DETAIL:  Syntax error in position 15.

Sure you don't just need to quote the values?

regression=# SELECT ts_headline('english', 'a b c', 'c'::tsquery,
$$StartSel='<span class="style1">', StopSel='</span>'$$);           ts_headline            
-----------------------------------a b <span class="style1">c</span>
(1 row)

        regards, tom lane

On Friday 14 September 2007 20:26:28 Tom Lane wrote:
> Andreas Joseph Krogh <andreak@officenet.no> writes:
> > In 8.2 this produces an error:
> >
> > SELECT headline('default', 'a b c', 'c'::tsquery,
> > 'StartSel=<span class="style1">, StopSel=</span>');
> > ERROR:  syntax error
> > DETAIL:  Syntax error in position 15.
>
> Sure you don't just need to quote the values?
>
> regression=# SELECT ts_headline('english', 'a b c', 'c'::tsquery,
> $$StartSel='<span class="style1">', StopSel='</span>'$$);
>             ts_headline
> -----------------------------------
>  a b <span class="style1">c</span>
> (1 row)
>
>
>             regards, tom lane

Doesn't work in 8.2:

andreak=# SELECT headline('default', 'a b c', 'c'::tsquery,
$$StartSel='<span class="style1">', StopSel='</span>'$$);
ERROR:  syntax error
DETAIL:  Syntax error in position 16.
andreak=# select version();                                           version
------------------------------------------------------------------------------------------------PostgreSQL 8.2.4 on
i686-pc-linux-gnu,compiled by GCC gcc (GCC) 4.1.2  
(Ubuntu 4.1.2-0ubuntu4)
(1 row)


--
Andreas Joseph Krogh <andreak@officenet.no>
Senior Software Developer / Manager
------------------------+---------------------------------------------+
OfficeNet AS            | The most difficult thing in the world is to |
Karenslyst Allé 11      | know how to do a thing and to watch         |
PO. Box 529 Skøyen      | somebody else doing it wrong, without       |
0214 Oslo               | comment.                                    |
NORWAY                  |                                             |
Tlf:    +47 24 15 38 90 |                                             |
Fax:    +47 24 15 38 91 |                                             |
Mobile: +47 909  56 963 |                                             |
------------------------+---------------------------------------------+

in 8.2
SELECT headline('default', 'a b c', 'c'::tsquery,
E'StartSel="<span class=\\"style1\\">", StopSel="</span>"');

>>> In 8.2 this produces an error:
>>>
>>> SELECT headline('default', 'a b c', 'c'::tsquery,
>>> 'StartSel=<span class="style1">, StopSel=</span>');
>>> ERROR:  syntax error

-- 
Teodor Sigaev                                   E-mail: teodor@sigaev.ru
  WWW: http://www.sigaev.ru/
 

On Tuesday 18 September 2007 17:15:43 Teodor Sigaev wrote:
> in 8.2
> SELECT headline('default', 'a b c', 'c'::tsquery,
> E'StartSel="<span class=\\"style1\\">", StopSel="</span>"');
>
> >>> In 8.2 this produces an error:
> >>>
> >>> SELECT headline('default', 'a b c', 'c'::tsquery,
> >>> 'StartSel=<span class="style1">, StopSel=</span>');
> >>> ERROR:  syntax error

Aha, thanks!

--
Andreas Joseph Krogh <andreak@officenet.no>
Senior Software Developer / Manager
------------------------+---------------------------------------------+
OfficeNet AS            | The most difficult thing in the world is to |
Karenslyst Allé 11      | know how to do a thing and to watch         |
PO. Box 529 Skøyen      | somebody else doing it wrong, without       |
0214 Oslo               | comment.                                    |
NORWAY                  |                                             |
Tlf:    +47 24 15 38 90 |                                             |
Fax:    +47 24 15 38 91 |                                             |
Mobile: +47 909  56 963 |                                             |
------------------------+---------------------------------------------+