Re: [PATCHES] GUC description cleanup

Поиск
Список
Период
Сортировка
Искать

Re: [PATCHES] GUC description cleanup

От:
Neil Conway <neilc@samurai.com>
Дата:
On Fri, 2006-10-27 at 15:59 +0200, Peter Eisentraut wrote:
> I appreciate this effort, but I think it's better to hold the patch.

Sure, I'll wait for 8.3 to branch.

-Neil

Re: [PATCHES] GUC description cleanup

От:
Neil Conway <neilc@samurai.com>
Дата:
On Sat, 2006-12-02 at 22:51 -0500, Tom Lane wrote:
> The bgwriter parameter descriptions seem still, well, not good English.

Indeed, there is still plenty of room for improvement, but exam period
prevents me from attempting anything more extensive at the moment...

Patch applied to HEAD.

-Neil

Re: [PATCHES] GUC description cleanup

От:
Tom Lane <tgl@sss.pgh.pa.us>
Дата:
Neil Conway  writes:
> Attached is a revised version of this patch.

The bgwriter parameter descriptions seem still, well, not good English.
For instance

> ! 			gettext_noop("Background writer maximum number of LRU pages to flush per round."),

ISTM this would read better as
	Maximum number of LRU pages to flush per activity round in the background writer.
or something else that betrays some understanding of English grammar ...

			regards, tom lane

Re: [PATCHES] GUC description cleanup

От:
Peter Eisentraut <peter_e@gmx.net>
Дата:
Am Donnerstag, 26. Oktober 2006 19:47 schrieb Neil Conway:
> Note that this patch breaks the translations of these strings, so I
> haven't applied it yet. Should I apply it now, or wait for 8.3 to
> branch?

I appreciate this effort, but I think it's better to hold the patch.

-- 
Peter Eisentraut
http://developer.postgresql.org/~petere/

Re: [PATCHES] GUC description cleanup

От:
"Josh Berkus" <josh@agliodbs.com>
Дата:
Neil,

> Sure, I'll wait for 8.3 to branch.

I have some cleanup I want to do for 8.3 too.  


Josh Berkus
PostgreSQL @ Sun
San Francisco 415-752-2500
FAQ