Обсуждение: Re: [PATCHES] Win32 BYTE_ORDER

"Magnus Hagander" <mha@sollentuna.net> writes:
> This patch adds a #define for BYTE_ORDER to win32.h if it's not pulled
> in elsewhere, as needed by msvc build of pgcrypto. Seems several other
> platforms define it in their port file already, but not win32.

Done, but I think you forgot the defs for LITTLE_ENDIAN and friends
... it seems unlikely that a platform would provide those and then
forget BYTE_ORDER.

            regards, tom lane

> > This patch adds a #define for BYTE_ORDER to win32.h if it's
> not pulled
> > in elsewhere, as needed by msvc build of pgcrypto. Seems
> several other
> > platforms define it in their port file already, but not win32.
>
> Done, but I think you forgot the defs for LITTLE_ENDIAN and
> friends ... it seems unlikely that a platform would provide
> those and then forget BYTE_ORDER.

Well, it compiled just fine, so it must've found it somewhere :-)

//Magnus

"Magnus Hagander" <mha@sollentuna.net> writes:
>> Done, but I think you forgot the defs for LITTLE_ENDIAN and
>> friends ... it seems unlikely that a platform would provide
>> those and then forget BYTE_ORDER.

> Well, it compiled just fine, so it must've found it somewhere :-)

I think the #if tests probably reduced to 0 == 0 ... so my bet is
it compiled but didn't work.

            regards, tom lane